Clang/mac: Declare stuff before using it.

Clang/mac: Declare stuff before using it.

In particular fullscreen_controller.mm:402:29: error: 'NSAnimation' may not respond to 'endFraction'

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49843

[Nico, 2010-06-15 22:16:15]

Updated the CL, it's now a 3-line diff

On Tue, Jun 15, 2010 at 3:10 PM, <thakis@chromium.org> wrote:

> Reviewers: rohitrao,
>
> Description:
> Clang/mac: Declare stuff before using it.
>
> In particular fullscreen_controller.mm:402:29: error: 'NSAnimation' may
> not
> respond to 'endFraction'
>
> Please review this at http://codereview.chromium.org/2836002/show
>
> Affected files:
>  M chrome/browser/cocoa/fullscreen_controller.h
>  M chrome/browser/cocoa/fullscreen_controller.mm
>
>
> Index: chrome/browser/cocoa/fullscreen_controller.h
> diff --git a/chrome/browser/cocoa/fullscreen_controller.h
> b/chrome/browser/cocoa/fullscreen_controller.h
> index
>
9d824b3ec94ab1d098c5b83cd45c083667989f17..554a88f6e7a53a7eaeac8c605c6ee4ac956479a2
> 100644
> --- a/chrome/browser/cocoa/fullscreen_controller.h
> +++ b/chrome/browser/cocoa/fullscreen_controller.h
> @@ -13,6 +13,30 @@
>
>  @class BrowserWindowController;
>
> +// Helper class to manage animations for the fullscreen dropdown bar.
>  Calls
> +// [FullscreenController changeFloatingBarShownFraction] once per
> animation
> +// step.
> +@interface DropdownAnimation : NSAnimation {
> + @private
> +  FullscreenController* controller_;
> +  CGFloat startFraction_;
> +  CGFloat endFraction_;
> +}
> +
> +@property(readonly, nonatomic) CGFloat startFraction;
> +@property(readonly, nonatomic) CGFloat endFraction;
> +
> +// Designated initializer.  Asks |controller| for the current shown
> fraction, so
> +// if the bar is already partially shown or partially hidden, the
> animation
> +// duration may be less than |fullDuration|.
> +- (id)initWithFraction:(CGFloat)fromFraction
> +          fullDuration:(CGFloat)fullDuration
> +        animationCurve:(NSInteger)animationCurve
> +            controller:(FullscreenController*)controller;
> +
> +@end
> +
> +
>  // Provides a controller to manage fullscreen mode for a single browser
> window.
>  // This class handles running animations, showing and hiding the floating
>  // dropdown bar, and managing the tracking area associated with the
> dropdown.
> @@ -46,7 +70,7 @@
>
>   // Pointer to the currently running animation.  Is nil if no animation is
>   // running.
> -  scoped_nsobject<NSAnimation> currentAnimation_;
> +  scoped_nsobject<DropdownAnimation> currentAnimation_;
>
>   // Timers for scheduled showing/hiding of the bar (which are always done
> with
>   // animation).
> Index: chrome/browser/cocoa/fullscreen_controller.mm
> diff --git
a/chrome/browser/cocoa/fullscreen_controller.mmb/chrome/browser/cocoa/
> fullscreen_controller.mm
> index
>
74de909b8b2d05bd7bc5afb87621679a97de6651..2bc1cc22d4f9b5d842164ad3342750ed1b61ff92
> 100644
> --- a/chrome/browser/cocoa/fullscreen_controller.mm
> +++ b/chrome/browser/cocoa/fullscreen_controller.mm
> @@ -28,29 +28,6 @@ const CGFloat kFloatingBarVerticalOffset = 22;
>  }  // end namespace
>
>
> -// Helper class to manage animations for the fullscreen dropdown bar.
>  Calls
> -// [FullscreenController changeFloatingBarShownFraction] once per
> animation
> -// step.
> -@interface DropdownAnimation : NSAnimation {
> - @private
> -  FullscreenController* controller_;
> -  CGFloat startFraction_;
> -  CGFloat endFraction_;
> -}
> -
> -@property(readonly, nonatomic) CGFloat startFraction;
> -@property(readonly, nonatomic) CGFloat endFraction;
> -
> -// Designated initializer.  Asks |controller| for the current shown
> fraction, so
> -// if the bar is already partially shown or partially hidden, the
> animation
> -// duration may be less than |fullDuration|.
> -- (id)initWithFraction:(CGFloat)fromFraction
> -          fullDuration:(CGFloat)fullDuration
> -        animationCurve:(NSInteger)animationCurve
> -            controller:(FullscreenController*)controller;
> -
> -@end
> -
>  @implementation DropdownAnimation
>
>  @synthesize startFraction = startFraction_;
>
>
>

[rohitrao (ping after 24h), 2010-06-15 22:18:07]

Much better =)

LGTM