Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 2835020: plugins: Add crash icon into the plugin crash alert infobar. (Closed)

Created:
10 years, 6 months ago by tfarina
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews, ben+cc_chromium.org, brettw-cc_chromium.org
Base URL:
git://git.chromium.org/chromium.git
Visibility:
Public.

Description

plugins: Add crash icon into the plugin crash alert infobar. BUG=16681 TEST=go to youtube.com, then go to a video, shift-esc, end flash process, see the infobar. Notice the icon in the left side. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51039

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/tab_contents/tab_contents.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
Hi Evan, could you review this to me?
10 years, 6 months ago (2010-06-26 02:49:18 UTC) #1
Evan Martin
10 years, 5 months ago (2010-06-28 19:09:12 UTC) #2
Sorry for the delay, I wanted to ask around about this first.

LGTM

Powered by Google App Engine
This is Rietveld 408576698