Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 2835018: Group plugins in about:plugins and show update link for out-of-date ones. (Closed)

Created:
10 years, 6 months ago by Bernhard Bauer
Modified:
9 years, 7 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, jam, Paweł Hajdan Jr., darin-cc_chromium.org, arv (Not doing code reviews), ben+cc_chromium.org, mavrommatis
Base URL:
git://codf21.jail/chromium.git
Visibility:
Public.

Description

Group plugins in about:plugins and show update link for out-of-date ones. Tracking patch by mavrommatis, original review here: <http://codereview.chromium.org/1991005>; Original description follows: (1) Group plugins with the same name together. (2) Show a download link for plugin versions with known security problems in about:plugins. BUG=3910 TEST=Open "chrome://plugins", see that plugins are grouped, and that any vulnerable plugins are marked red. Try enabling and disabling plugin groups. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51110

Patch Set 1 #

Patch Set 2 : Sync to http://codereview.chromium.org/2809033 #

Patch Set 3 : Sync; Actually disable disabled plugin groups. #

Patch Set 4 : Fix compile errors caused by merge. #

Patch Set 5 : Fix compile errors in unit test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+979 lines, -255 lines) Patch
M chrome/app/generated_resources.grd View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/dom_ui/plugins_ui.cc View 1 2 6 chunks +31 lines, -95 lines 0 comments Download
M chrome/browser/plugin_service.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/plugin_service.cc View 1 2 3 2 chunks +3 lines, -78 lines 0 comments Download
A chrome/browser/plugin_updater.h View 1 chunk +141 lines, -0 lines 0 comments Download
A chrome/browser/plugin_updater.cc View 1 2 3 1 chunk +524 lines, -0 lines 0 comments Download
A chrome/browser/plugin_updater_unittest.cc View 1 2 3 4 1 chunk +112 lines, -0 lines 0 comments Download
M chrome/browser/resources/plugins.html View 7 chunks +154 lines, -76 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Bernhard Bauer
Hi Trung, I synced the CL again, and the trybot results look good to me ...
10 years, 5 months ago (2010-06-28 14:57:53 UTC) #1
viettrungluu
10 years, 5 months ago (2010-06-28 15:05:10 UTC) #2
Sure, go for it. Watch the Windows bots though. (I thought I knew what the
unit_test failure was, but I can't find it in my email. The initial failure
which closed the tree was probably an unrelated flaky fail.)

Thanks!

- Trung

On 2010/06/28 14:57:53, Bernhard Bauer wrote:
> Hi Trung, 
> 
> I synced the CL again, and the trybot results look good to me (there was a
test
> failure on win that looked unrelated; I'm running it again).
> 
> Do you think we could try and land this?
> 
> Bernhard.

Powered by Google App Engine
This is Rietveld 408576698