Issue 2834055: Update mod_image_for_test to support --fast option.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2834055: Update mod_image_for_test to support --fast option. (Closed)

Created:
10 years, 5 months ago by davidjames

Modified:
9 years, 4 months ago

Reviewers:
Nick Sanders

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@chromiumos-git/crosutils.git

Visibility:
Public.

Description

Update mod_image_for_test to support --fast option. Added --fast option. Updated the one place that wasn't using sudo when calling emerge to use sudo like the others. This is safe because we're merging with --usepkgonly. TEST=Ran mod_image_for_test.sh with and without the --fast options BUG=none

Patch Set 1 #

Total comments: 1

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	mod_image_for_test.sh	View		3 chunks	+6 lines, -4 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nick Sanders

10 years, 5 months ago (2010-07-20 07:30:16 UTC) #3

lgtm

http://codereview.chromium.org/2834055/diff/1/2
File mod_image_for_test.sh (right):

http://codereview.chromium.org/2834055/diff/1/2#newcode35
mod_image_for_test.sh:35: DEFINE_boolean fast ${FLAGS_FALSE} "Call many emerges
in parallel"
can you add passthough to image_to_usb? not necessary for this cl tho

Expand Messages | Collapse Messages