Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2834051: Set sync-notification-method to "transitional" for integration tests. (Closed)

Created:
10 years, 5 months ago by Raghu Simha
Modified:
9 years, 7 months ago
Reviewers:
ncarter (slow), akalin
CC:
chromium-reviews, Paweł Hajdan Jr., tim (not reviewing), idana
Visibility:
Public.

Description

Set sync-notification-method to "transitional" for integration tests. The sync integration tests do not have a fake Tango server that provides clients with XMPP notifications. Therefore, we rely on clients nudging each other via the server when changes need to be synced. Until we implement a fake Tango server, this switch needs to be set for all integration tests. BUG=48141 TEST=sync_integration_tests:echo Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52939

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M chrome/test/live_sync/live_sync_test.cc View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Raghu Simha
10 years, 5 months ago (2010-07-17 00:08:42 UTC) #1
Raghu Simha
On 2010/07/17 00:08:42, rsimha wrote: > Ping :)
10 years, 5 months ago (2010-07-19 18:28:32 UTC) #2
ncarter (slow)
LGTM
10 years, 5 months ago (2010-07-19 18:31:49 UTC) #3
akalin
LGTM On 2010/07/19 18:31:49, ncarter wrote: > LGTM
10 years, 5 months ago (2010-07-19 19:37:33 UTC) #4
Raghu Simha
10 years, 5 months ago (2010-07-19 19:39:17 UTC) #5
Thanks!

Powered by Google App Engine
This is Rietveld 408576698