Add IssueAuthToken and unit tests to GaiaAuthenticator2.

Add IssueAuthToken and unit tests to GaiaAuthenticator2.
GaiaAuthConsumer pure virtuals now optional since you can choose to not listen to ClientLogin subscriptions.
Renamed ClientLoginError to a general GaiaAuthError.
BUG=47093
TEST=Unit tests included

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51678

[chron_chromium.org, 2010-07-06 02:43:31]

zork,

Please take a look at this CL.

cmasone,

This CL is going to zork since the united states is OOO today and tomorrow. This
change is pretty small and doesn't touch much ChromeOS code so I think it should
be fine to send to a Chrome reviewer. Feel free to look anyway if you like.

[Zachary Kuznia, 2010-07-06 03:33:23]

LGTM

http://codereview.chromium.org/2834042/diff/1/6
File chrome/common/net/gaia/gaia_authenticator2.cc (right):

http://codereview.chromium.org/2834042/diff/1/6#newcode253
chrome/common/net/gaia/gaia_authenticator2.cc:253: }
Perhaps make this an "} else {" to make the flow of this function more clear.

[tim (not reviewing), 2010-07-07 02:50:19]

I mentioned this briefly in your design doc, and seeing this code I see a lot of
similarity between your auth error struct and
chrome/browser/google_service_auth_error.h.  That one looks a little more
robust, and additionally supports captcha.  

Can't we use it instead?

On 2010/07/06 03:33:23, Zachary Kuznia wrote:
> LGTM
> 
> http://codereview.chromium.org/2834042/diff/1/6
> File chrome/common/net/gaia/gaia_authenticator2.cc (right):
> 
> http://codereview.chromium.org/2834042/diff/1/6#newcode253
> chrome/common/net/gaia/gaia_authenticator2.cc:253: }
> Perhaps make this an "} else {" to make the flow of this function more clear.

[chron_chromium.org, 2010-07-07 05:05:34]

I'll reconcile the two in a follow up CL since it would touch a lot of
files.

On Tue, Jul 6, 2010 at 7:50 PM, <tim@chromium.org> wrote:

> I mentioned this briefly in your design doc, and seeing this code I see a
> lot of
> similarity between your auth error struct and
> chrome/browser/google_service_auth_error.h.  That one looks a little more
> robust, and additionally supports captcha.
>
> Can't we use it instead?
>
>
> On 2010/07/06 03:33:23, Zachary Kuznia wrote:
>
>> LGTM
>>
>
>  http://codereview.chromium.org/2834042/diff/1/6
>> File chrome/common/net/gaia/gaia_authenticator2.cc (right):
>>
>
>  http://codereview.chromium.org/2834042/diff/1/6#newcode253
>> chrome/common/net/gaia/gaia_authenticator2.cc:253: }
>> Perhaps make this an "} else {" to make the flow of this function more
>> clear.
>>
>
>
>
> http://codereview.chromium.org/2834042/show
>