Issue 2834038: [PATCH 5/5] build_image: refactor bootloaders and enable vboot config paths

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2834038: [PATCH 5/5] build_image: refactor bootloaders and enable vboot config paths (Closed)

Created:
10 years, 5 months ago by Will Drewry

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Visibility:
Public.

Description

[PATCH 5/5] build_image: refactor bootloaders and enable vboot config paths This change adds make_image_bootable which combines the prior changes to make ARM, x86-legacy, x86-efi, and x86-fw share kernel commandlines (where possible) and not rely on keeping data stored on the rootfs to do so. It does not enable a cut over to syslinux yet, though. TEST=manually built image and tested boot and install (in progress) BUG=chromium-os:327

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+138 lines, -50 lines)			Patch
	M	build_image	View		17 chunks	+138 lines, -50 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages