Issue 2834022: Ensure that ToPrimitive is called on all objects involved in comparisons <, <...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2834022: Ensure that ToPrimitive is called on all objects involved in comparisons <, <... (Closed)

Created:
10 years, 6 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Ensure that ToPrimitive is called on all objects involved in comparisons <, <=, >, >=. Ensures that ToPrimitive is called when comparing an object to undefined. Fixes bugs on all platforms. Committed: http://code.google.com/p/v8/source/detail?r=4971

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+117 lines, -16 lines)			Patch
M	src/ia32/codegen-ia32.cc	View	1	1 chunk	+9 lines, -7 lines	0 comments	Download
M	src/runtime.js	View		2 chunks	+8 lines, -4 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	1	1 chunk	+14 lines, -5 lines	0 comments	Download
M	test/mjsunit/to_number_order.js	View	2	2 chunks	+86 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM with a test added (either in this changelist or as a separate follow-up changelist). ...

10 years, 6 months ago (2010-06-24 15:39:40 UTC) #2

William Hesse

Unit test added, fix for problem in runtime.js COMPARE added.

10 years, 5 months ago (2010-06-28 14:23:04 UTC) #3

LGTM

Expand Messages | Collapse Messages