Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1254)

Unified Diff: remoting/client/plugin/chromoting_plugin.cc

Issue 2834021: Revert 50667 - Add in support for internal pepper plugins into the PepperPlug... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/client/plugin/chromoting_plugin.h ('k') | remoting/client/plugin/pepper_entrypoints.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/client/plugin/chromoting_plugin.cc
===================================================================
--- remoting/client/plugin/chromoting_plugin.cc (revision 50670)
+++ remoting/client/plugin/chromoting_plugin.cc (working copy)
@@ -23,15 +23,13 @@
namespace remoting {
-const char* ChromotingPlugin::kMimeType = "pepper-application/x-chromoting";
+const char* ChromotingPlugin::kMimeType =
+ "pepper-application/x-chromoting-plugin::Chromoting";
-ChromotingPlugin::ChromotingPlugin(PP_Instance pp_instance,
- const PPB_Instance* ppb_instance_funcs)
- : width_(0),
- height_(0),
- drawing_context_(NULL),
- pp_instance_(pp_instance),
- ppb_instance_funcs_(ppb_instance_funcs) {
+ChromotingPlugin::ChromotingPlugin(PP_Instance instance)
+ : pp::Instance(instance),
+ width_(0),
+ height_(0) {
}
ChromotingPlugin::~ChromotingPlugin() {
@@ -49,8 +47,7 @@
main_thread_->Stop();
}
-bool ChromotingPlugin::Init(uint32_t argc, const char* argn[],
- const char* argv[]) {
+bool ChromotingPlugin::Init(uint32_t argc, const char* argn[], const char* argv[]) {
LOG(INFO) << "Started ChromotingPlugin::Init";
// Extract the URL from the arguments.
@@ -115,13 +112,8 @@
width_ = position.size.width;
height_ = position.size.height;
- /*
- * TODO(ajwong): Reenable this code once we fingure out how we want to
- * abstract away the C-api for DeviceContext2D.
device_context_ = pp::DeviceContext2D(width_, height_, false);
- if (!ppb_instance_funcs_->BindGraphicsDeviceContext(
- pp_instance_,
- device_context_.pp_resource())) {
+ if (!BindGraphicsDeviceContext(device_context_)) {
LOG(ERROR) << "Couldn't bind the device context.";
return;
}
@@ -138,7 +130,6 @@
} else {
LOG(ERROR) << "Unable to allocate image.";
}
- */
//client_->SetViewport(0, 0, width_, height_);
//client_->Repaint();
« no previous file with comments | « remoting/client/plugin/chromoting_plugin.h ('k') | remoting/client/plugin/pepper_entrypoints.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698