Implement Password Manager aggregate metrics reporting

Implement Password Manager aggregate metrics reporting

This patch implements UMA histograms for the total number of saved passwords and the number of usernames per site/realm.

    BUG=45946
R=jcivelli@chromium.org
    TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50677

[Dirk Pranke, 2010-06-16 22:39:30]

Note that this depends on the previous patch for the interface stubs.

[Jay Civelli, 2010-06-17 06:07:31]

LGTM

http://codereview.chromium.org/2834009/diff/1/2
File chrome/browser/password_manager/login_database.cc (right):

http://codereview.chromium.org/2834009/diff/1/2#newcode132
chrome/browser/password_manager/login_database.cc:132: "SELECT signon_realm,
COUNT(username_value) FROM logins"));
Nit: should be 4 space indented

[Dirk Pranke, 2010-06-17 23:37:54]

http://codereview.chromium.org/2834009/diff/1/2
File chrome/browser/password_manager/login_database.cc (right):

http://codereview.chromium.org/2834009/diff/1/2#newcode132
chrome/browser/password_manager/login_database.cc:132: "SELECT signon_realm,
COUNT(username_value) FROM logins"));
On 2010/06/17 06:07:31, Jay Civelli wrote:
> Nit: should be 4 space indented

Done.

[Dirk Pranke, 2010-06-18 00:18:15]

Jay,

Can you take another look? Turns out the Mac port was one line, and I had a bug
in the login database SQL code anyway.

[Jay Civelli, 2010-06-18 00:22:19]

LGTM