Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2833052: [chromeos]Set GtkWidget's default direction correctly. (Closed)

Created:
10 years, 5 months ago by James Su
Modified:
9 years, 7 months ago
Reviewers:
xji
CC:
chromium-reviews, brettw-cc_chromium.org
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

[chromeos]Set GtkWidget's default direction correctly. BUG=41558 TEST=Login ChromeOS with a RTL language, the text in the omnibox should be right aligned. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51471

Patch Set 1 #

Patch Set 2 : Update comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M base/i18n/rtl.cc View 1 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
James Su
10 years, 5 months ago (2010-07-02 00:43:06 UTC) #1
xji
10 years, 5 months ago (2010-07-02 01:25:01 UTC) #2
On 2010/07/02 00:43:06, James Su wrote:
> 

LGTM.

Powered by Google App Engine
This is Rietveld 408576698