Issue 2833048: ARM: Don't emit a write barrier for an inlined keyed load...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2833048: ARM: Don't emit a write barrier for an inlined keyed load... (Closed)

Created:
10 years, 5 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

ARM: Don't emit a write barrier for an inlined keyed load if the right hand side is a literal like true, false, etc. Also if the value is not a likely Smi we inline the newspace check. Committed: http://code.google.com/p/v8/source/detail?r=4999

Patch Set 1 #

Total comments: 2

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -25 lines)			Patch
	M	src/arm/codegen-arm.h	View		3 chunks	+3 lines, -2 lines	0 comments	Download
	M	src/arm/codegen-arm.cc	View		14 chunks	+67 lines, -23 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

10 years, 5 months ago (2010-07-01 15:00:59 UTC) #2

LGTM.

http://codereview.chromium.org/2833048/diff/1/2
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/2833048/diff/1/2#newcode6394
src/arm/codegen-arm.cc:6394: // If the value is not likely to be a Smi then lets
test the fixed array
let's

http://codereview.chromium.org/2833048/diff/1/2#newcode6426
src/arm/codegen-arm.cc:6426: // is not a dictionary.
The check that it is a dictionary is pretty far away from here.

Expand Messages | Collapse Messages