sync: Get rid of the now obsolete character_set_converters.h API.

sync: Get rid of the now obsolete character_set_converters.h API.

No one is using the utility functions in there, with the one exception.
So fixed that case and removed the obsolete API.

BUG=26443
TEST=trybots

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51605

[tfarina, 2010-07-01 03:51:40]

Hi Nick, could you review this to me?

[ncarter (slow), 2010-07-01 21:46:51]

Thanks for this cleanup!

LGTM with formatting fix.

http://codereview.chromium.org/2833047/diff/1/7
File chrome/browser/sync/util/user_settings_unittest.cc (right):

http://codereview.chromium.org/2833047/diff/1/7#newcode84
chrome/browser/sync/util/user_settings_unittest.cc:84: #endif
Preprocessor macros are typically not indented (no whitespace before the #if /
#elif); and they don't add extra indentation to code they surround
(statement.bind_string should be flush with the earlier lines)

[tfarina, 2010-07-02 03:07:13]

http://codereview.chromium.org/2833047/diff/1/7
File chrome/browser/sync/util/user_settings_unittest.cc (right):

http://codereview.chromium.org/2833047/diff/1/7#newcode84
chrome/browser/sync/util/user_settings_unittest.cc:84: #endif
On 2010/07/01 21:46:51, ncarter wrote:
> Preprocessor macros are typically not indented (no whitespace before the #if /
> #elif); and they don't add extra indentation to code they surround
> (statement.bind_string should be flush with the earlier lines)
Yeah, I was in doubt, thanks for the hint. Fixed it. OK to commit?

[tfarina, 2010-07-03 15:02:47]

On 2010/07/01 21:46:51, ncarter wrote:
> Thanks for this cleanup!
> 
> LGTM with formatting fix.
> 
Format fixed, committing now...