Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2833042: Enable extensions sync by default. (Closed)

Created:
10 years, 5 months ago by akalin
Modified:
9 years, 7 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews, Raghu Simha, ncarter (slow), ben+cc_chromium.org, tim (not reviewing), idana, Paweł Hajdan Jr.
Visibility:
Public.

Description

Enable extensions sync by default. BUG=32413 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51226

Patch Set 1 #

Patch Set 2 : Fixed unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -8 lines) Patch
M chrome/browser/sync/profile_sync_factory_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_factory_impl_unittest.cc View 5 chunks +25 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
akalin
+nick for review
10 years, 5 months ago (2010-06-30 02:41:25 UTC) #1
ncarter (slow)
You've got to change the test expectations too -- look for the commits Tim did ...
10 years, 5 months ago (2010-06-30 03:04:56 UTC) #2
akalin
On 2010/06/30 03:04:56, ncarter wrote: > You've got to change the test expectations too -- ...
10 years, 5 months ago (2010-06-30 03:18:01 UTC) #3
ncarter (slow)
10 years, 5 months ago (2010-06-30 04:05:03 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698