Issue 2833006: Eliminate stale pkcs11 certificate handler implementations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2833006: Eliminate stale pkcs11 certificate handler implementations. (Closed)

Created:
10 years, 6 months ago by stevenjb

Modified:
9 years, 7 months ago

Reviewers:
rginda

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@chromiumos-git/entd.git

Visibility:
Public.

Description

Eliminate stale pkcs11 certificate handler implementations. Cleaned up pkcs11 initiailization code.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Changed default pkcs11 mode and updated tests. #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+105 lines, -537 lines)			Patch
M	entd.h	View		2 chunks	+0 lines, -7 lines	0 comments	Download
M	entd.cc	View	1	1 chunk	+6 lines, -11 lines	0 comments	Download
M	main.cc	View		3 chunks	+0 lines, -5 lines	0 comments	Download
M	pkcs11.h	View		1 chunk	+13 lines, -16 lines	0 comments	Download
M	pkcs11.cc	View		8 chunks	+57 lines, -486 lines	0 comments	Download
M	run_tests.sh	View	1	5 chunks	+29 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rginda

Please also make --pkcs11=opencryptoki the default, and update init/entd.conf so that things are started properly. ...

10 years, 6 months ago (2010-06-15 17:38:54 UTC) #2

stevenjb

On 2010/06/15 17:38:54, rginda wrote: > Please also make --pkcs11=opencryptoki the default, and update init/entd.conf ...

10 years, 6 months ago (2010-06-15 21:41:38 UTC) #3

rginda

10 years, 6 months ago (2010-06-16 00:15:07 UTC) #4

lgtm

On 2010/06/15 21:41:38, Steven Bennetts wrote:
> On 2010/06/15 17:38:54, rginda wrote:
> > Please also make --pkcs11=opencryptoki the default, and update
init/entd.conf
> so
> > that things are started properly.
> > 
> Done.
> 
> > http://codereview.chromium.org/2833006/diff/1/2
> > File entd.cc (right):
> > 
> > http://codereview.chromium.org/2833006/diff/1/2#newcode402
> > entd.cc:402: res = res && pkcs11_->SetOpenSSLHandlers();
> > need some braces here.
> Done.

Expand Messages | Collapse Messages