Unpin deleted URLs + better deleting algorithm.

Unpin deleted URLs + better deleting algorithm.

BUG=none
TEST=TopSitesTest

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54003

[Nik Shkrob, 2010-07-28 18:25:08]

http://codereview.chromium.org/2832091/diff/1/2
File chrome/browser/history/top_sites.cc (left):

http://codereview.chromium.org/2832091/diff/1/2#oldcode810
chrome/browser/history/top_sites.cc:810: top_sites_.erase(top_sites_.begin() +
i);
Fixed deleting from top_sites_ while iterating over it.

[brettw, 2010-07-28 18:37:20]

http://codereview.chromium.org/2832091/diff/1/2
File chrome/browser/history/top_sites.cc (right):

http://codereview.chromium.org/2832091/diff/1/2#newcode822
chrome/browser/history/top_sites.cc:822: canonical_urls_.clear();
Could doing this break anything that happens in between the time that you clear
the list and the time that the new query completes?

[Nik Shkrob, 2010-07-28 19:02:19]

http://codereview.chromium.org/2832091/diff/1/2
File chrome/browser/history/top_sites.cc (right):

http://codereview.chromium.org/2832091/diff/1/2#newcode822
chrome/browser/history/top_sites.cc:822: canonical_urls_.clear();
On 2010/07/28 18:37:20, brettw wrote:
> Could doing this break anything that happens in between the time that you
clear
> the list and the time that the new query completes?

Done.

[brettw, 2010-07-28 19:41:34]

LGTM