Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 2832079: Remove .svn files from the client directory to save space (Closed)

Created:
10 years, 5 months ago by Paul Stewart
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Base URL:
ssh://gitrw.chromium.org/crosutils.git
Visibility:
Public.

Description

Remove .svn files from the client directory to save space Copying the .ssh directories within client takes up O(2n) space in the stateful partition BUG=none TEST=reran mod_image_for_test.sh

Patch Set 1 #

Total comments: 4

Patch Set 2 : Use rsync instead of cp. Ad deps/chrome_test to exclude list #

Patch Set 3 : Merge to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -17 lines) Patch
M mod_image_for_test.sh View 1 2 2 chunks +12 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Daniel Erat
http://codereview.chromium.org/2832079/diff/1/2 File mod_image_for_test.sh (right): http://codereview.chromium.org/2832079/diff/1/2#newcode141 mod_image_for_test.sh:141: sudo cp -fpru ${AUTOTEST_SRC}/client/* \ What about using rsync ...
10 years, 5 months ago (2010-07-23 18:58:59 UTC) #1
Nick Sanders
http://codereview.chromium.org/2832079/diff/1/2 File mod_image_for_test.sh (right): http://codereview.chromium.org/2832079/diff/1/2#newcode148 mod_image_for_test.sh:148: sudo rm -rf /tmp/autotest/realtimecomm_GTalk* can you add an exclusion ...
10 years, 5 months ago (2010-07-23 19:45:09 UTC) #2
Nick Sanders
lgtm, looks pretty beneficial as is.
10 years, 4 months ago (2010-08-06 22:12:13 UTC) #3
Paul Stewart
Both suggestions are incorporated. I tested by using ./mod_image_for_test.sh --factory. It asked me to patch ...
10 years, 4 months ago (2010-08-07 00:51:57 UTC) #4
Daniel Erat
10 years, 4 months ago (2010-08-07 05:45:36 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698