Issue 2832061: Break out histogram counter variables as CookieMonster instance variables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2832061: Break out histogram counter variables as CookieMonster instance variables. (Closed)

Created:
10 years, 5 months ago by Randy Smith (Not in Mondays)

Modified:
9 years, 7 months ago

Reviewers:
jar (doing other things)

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Visibility:
Public.

Description

Break out histogram counter variables as CookieMonster instance variables. This avoids racing on the initialization of the statics usually declared when doing histogram accumulation. BUG=49142 TEST=net_unittests --gtest_filter=CookieMonsterTest.*:ParsedCookieTest.* (to confirm I didn't break anyting; this doesn't reproduce the race.) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53042

Patch Set 1 #

Patch Set 2 : Removed syntactic sugar and get() check. #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -21 lines)			Patch
M	chrome/test/data/reliability/known_crashes.txt	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	net/base/cookie_monster.h	View	1	2 chunks	+14 lines, -0 lines	0 comments	Download
M	net/base/cookie_monster.cc	View	1	8 chunks	+69 lines, -18 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Randy Smith (Not in Mondays)

Jim: Here you go; let me know what you think. If you could also keep ...

10 years, 5 months ago (2010-07-19 19:50:26 UTC) #1

jar (doing other things)

10 years, 5 months ago (2010-07-19 21:56:43 UTC) #2

LGTM

I tried to check all parameters/bounds... watched out for LinearHistogram (used
only in enumerations), etc.  

Be sure you can get the try bots green, as sometimes these subtle changes can
bother one platform or the other.

Expand Messages | Collapse Messages