Issue 2832048: Cleanup: Reword a label from "command line switches" to "command line", as th...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2832048: Cleanup: Reword a label from "command line switches" to "command line", as th... (Closed)

Created:
10 years, 5 months ago by eroman

Modified:
9 years, 6 months ago

Reviewers:
cbentzel

CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Cleanup: Reword a label from "command line switches" to "command line", as that is more accurate. BUG=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51582

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/resources/net_internals/dataview.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

cbentzel

10 years, 5 months ago (2010-07-02 20:56:42 UTC) #2

LGTM

On Fri, Jul 2, 2010 at 4:51 PM, <eroman@chromium.org> wrote:

> Reviewers: cbentzel,
>
> Description:
> Cleanup: Reword a label from "command line switches" to "command line", as
> that
> is more accurate.
>
> BUG=NONE
>
> Please review this at http://codereview.chromium.org/2832048/show
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/resources/net_internals/dataview.js
>
>
> Index: chrome/browser/resources/net_internals/dataview.js
> ===================================================================
> --- chrome/browser/resources/net_internals/dataview.js  (revision 51548)
> +++ chrome/browser/resources/net_internals/dataview.js  (working copy)
> @@ -44,7 +44,7 @@
>             ' (' + ClientInfo.official +
>             ' ' + ClientInfo.cl +
>             ') ' + ClientInfo.version_mod);
> -  text.push('Command line switches: ' + ClientInfo.command_line);
> +  text.push('Command line: ' + ClientInfo.command_line);
>
>   text.push('');
>   text.push('----------------------------------------------');
>
>
>

Expand Messages | Collapse Messages