Issue 2832043: Fixes leaks in remote_unittest....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2832043: Fixes leaks in remote_unittest.... (Closed)

Created:
10 years, 5 months ago by Hironori Bono

Modified:
9 years, 7 months ago

Reviewers:
garykac

CC:
chromium-reviews, Alpha Left Google, Sergey Ulanov, dmac, awong, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Fixes leaks in remote_unittest. This change just replaces pointers used in remote_unittest with scoped_ptr<> to delete the memory used in the test, and replaces scoped_ptr<> in differ.h with scoped_array<> to avoid mismatched deletes. BUG=46678 TEST=make valgrind bots green. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51493

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -16 lines)			Patch
	M	remoting/host/differ.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	remoting/host/differ_unittest.cc	View		8 chunks	+15 lines, -15 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

On 2010/07/01 05:41:47, hbono wrote:
> 

LGTM

Expand Messages | Collapse Messages