Refactor the implementation of InputWindowDialog.

Refactor the implementation of InputWindowDialog.

- Move the implementation of each platform under its respective source directory.
- Rename the classes to match with pattern used in the chrome source.
- In the gtk side, use the gtk signal macros for the callback events.

BUG=None
TEST=open the bookmark editor dialog, everything should works as before on windows and linux.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52721

[tfarina, 2010-07-08 16:11:43]

Hi Scott, could you review this to me?

[sky, 2010-07-08 16:23:42]

Ben is a better person to review this one.

  -Scott

On Thu, Jul 8, 2010 at 9:11 AM,  <tfarina@chromium.org> wrote:
> Reviewers: sky,
>
> Message:
> Hi Scott, could you review this to me?
>
> Description:
> Refactor the implementation of InputWindowDialog.
>
> - Move the implementation of each platform under its respective source
> directory.
> - Rename the classes to match with pattern used in the chrome source.
> - In the gtk side, use the gtk signal macros for the callback events.
>
> BUG=None
> TEST=open the bookmark editor dialog, everything should works as before on
> windows and linux.
>
> Please review this at http://codereview.chromium.org/2832028/show
>
> Affected files:
>  A chrome/browser/gtk/input_window_dialog_gtk.h
>  A + chrome/browser/gtk/input_window_dialog_gtk.cc
>  D chrome/browser/input_window_dialog_win.cc
>  A chrome/browser/views/input_window_dialog_win.h
>  A chrome/browser/views/input_window_dialog_win.cc
>  M chrome/chrome_browser.gypi
>
>
>

[tfarina, 2010-07-08 19:39:13]

On 2010/07/08 16:23:42, sky wrote:
> Ben is a better person to review this one.
> 
Ben, could you take a look instead?

[tfarina, 2010-07-11 22:08:00]

Ping Ben!

[tfarina, 2010-07-15 03:13:03]

On 2010/07/11 22:08:00, tfarina wrote:
> Ping Ben!

Ping2!!

[tfarina, 2010-07-16 16:30:21]

On 2010/07/15 03:13:03, tfarina wrote:
> On 2010/07/11 22:08:00, tfarina wrote:
> > Ping Ben!
> 
> Ping2!!
Scott, why you can't review this? Is there someone else that could?

[sky, 2010-07-16 17:06:58]

On Fri, Jul 16, 2010 at 9:30 AM,  <tfarina@chromium.org> wrote:
> On 2010/07/15 03:13:03, tfarina wrote:
>>
>> On 2010/07/11 22:08:00, tfarina wrote:
>> > Ping Ben!
>
>> Ping2!!
>
> Scott, why you can't review this? Is there someone else that could?

It's always best to get the author of the code to review changes to it.

  -Scott

[tfarina, 2010-07-16 17:15:52]

On 2010/07/16 17:06:58, sky wrote:
> On Fri, Jul 16, 2010 at 9:30 AM,  <mailto:tfarina@chromium.org> wrote:
> > On 2010/07/15 03:13:03, tfarina wrote:
> >>
> >> On 2010/07/11 22:08:00, tfarina wrote:
> >> > Ping Ben!
> >
> >> Ping2!!
> >
> > Scott, why you can't review this? Is there someone else that could?
> 
> It's always best to get the author of the code to review changes to it.
> 
OK, looks like Elliot wrote this code. +r erg for review.

Elliot, could you take a look at this?

[Elliot Glaysher, 2010-07-16 17:33:47]

> Elliot, could you take a look at this?

LGTM. Doesn't look like this does any real code modifications, just moving files
and names around.

[tfarina, 2010-07-16 17:50:34]

On 2010/07/16 17:33:47, Elliot Glaysher wrote:
> > Elliot, could you take a look at this?
> 
> LGTM. Doesn't look like this does any real code modifications, just moving
files
> and names around.
Yup, and changed to use the CHROMEG macros, committing now...