Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2832022: Modify global_config.ini to support packager of autotest client. (Closed)

Created:
10 years, 6 months ago by ericli
Modified:
9 years, 7 months ago
Reviewers:
kdlucas, seano, truty
CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, ericli, petkov+cc_chromium.org
Base URL:
ssh://git@chromiumos-git/autotest.git
Visibility:
Public.

Description

Modify global_config.ini to support packager of autotest client. This is the first step to package autotest client onto stateful partition. Other changes will be made in ebuild files in other git. It should have no impact to any existing autotest users.

Patch Set 1 #

Total comments: 2

Patch Set 2 : patch #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M global_config.ini View 2 chunks +8 lines, -3 lines 1 comment Download

Messages

Total messages: 7 (0 generated)
ericli
10 years, 6 months ago (2010-06-23 20:39:11 UTC) #1
truty
http://codereview.chromium.org/2832022/diff/1/2 File global_config.ini (left): http://codereview.chromium.org/2832022/diff/1/2#oldcode33 global_config.ini:33: client_autodir_paths: /usr/local/autotest,/home/autotest Why are we removing this?
10 years, 6 months ago (2010-06-24 16:26:43 UTC) #2
ericli
http://codereview.chromium.org/2832022/diff/1/2 File global_config.ini (left): http://codereview.chromium.org/2832022/diff/1/2#oldcode33 global_config.ini:33: client_autodir_paths: /usr/local/autotest,/home/autotest This is a duplicated entry, see line ...
10 years, 6 months ago (2010-06-24 16:29:50 UTC) #3
truty
LGTM
10 years, 6 months ago (2010-06-24 16:35:17 UTC) #4
kdlucas
LGTM Just curious why you removed the AUTOSERV section.
10 years, 6 months ago (2010-06-24 17:04:35 UTC) #5
ericli
That is a duplicated section. See line 100, which has no effect. On Thu, Jun ...
10 years, 6 months ago (2010-06-24 17:07:56 UTC) #6
seano
10 years, 6 months ago (2010-06-24 20:06:02 UTC) #7
LGTM

http://codereview.chromium.org/2832022/diff/6001/7001
File global_config.ini (right):

http://codereview.chromium.org/2832022/diff/6001/7001#newcode112
global_config.ini:112: upload_location: UNUSED
Do you need UNUSED, or can you just leave it blank?

Powered by Google App Engine
This is Rietveld 408576698