Issue 2832011: Change scripts/common.sh to allow the users build Valgrind binaries from the ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2832011: Change scripts/common.sh to allow the users build Valgrind binaries from the ... (Closed)

Created:
10 years, 6 months ago by Alexander Potapenko

Modified:
9 years, 6 months ago

Reviewers:
Timur Iskhodzhanov

CC:
chromium-reviews, John Grabowski

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/third_party/valgrind/

Visibility:
Public.

Description

Change scripts/common.sh to allow the users build Valgrind binaries from the MACOSX106 branch on Snow Leopard. Add precompiled Valgrind (Memcheck only) binaries built from the branch r11175 (VEX r1982) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50224

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1756 lines, -3 lines)			Patch
A	binaries/mac_10.6/bin/ms_print	View		1 chunk	+680 lines, -0 lines	0 comments	Download
A	binaries/mac_10.6/bin/no_op_client_for_valgrind	View		Binary file		0 comments	Download
A	binaries/mac_10.6/bin/valgrind	View		Binary file		0 comments	Download
A	binaries/mac_10.6/bin/valgrind-listener	View		Binary file		0 comments	Download
A	binaries/mac_10.6/lib/valgrind/default.supp	View		1 chunk	+887 lines, -0 lines	0 comments	Download
A	binaries/mac_10.6/lib/valgrind/libmpiwrap-amd64-darwin.so	View		Binary file		0 comments	Download
A	binaries/mac_10.6/lib/valgrind/libmpiwrap-amd64-darwin.so.dSYM/Contents/Info.plist	View		1 chunk	+20 lines, -0 lines	0 comments	Download
A	binaries/mac_10.6/lib/valgrind/libmpiwrap-amd64-darwin.so.dSYM/Contents/Resources/DWARF/libmpiwrap-amd64-darwin.so	View		Binary file		0 comments	Download
A	binaries/mac_10.6/lib/valgrind/libmpiwrap-x86-darwin.so	View		Binary file		0 comments	Download
A	binaries/mac_10.6/lib/valgrind/libmpiwrap-x86-darwin.so.dSYM/Contents/Info.plist	View		1 chunk	+20 lines, -0 lines	0 comments	Download
A	binaries/mac_10.6/lib/valgrind/libmpiwrap-x86-darwin.so.dSYM/Contents/Resources/DWARF/libmpiwrap-x86-darwin.so	View		Binary file		0 comments	Download
A	binaries/mac_10.6/lib/valgrind/memcheck-amd64-darwin	View		Binary file		0 comments	Download
A	binaries/mac_10.6/lib/valgrind/memcheck-amd64-darwin.dSYM/Contents/Info.plist	View		1 chunk	+20 lines, -0 lines	0 comments	Download
A	binaries/mac_10.6/lib/valgrind/memcheck-amd64-darwin.dSYM/Contents/Resources/DWARF/memcheck-amd64-darwin	View		Binary file		0 comments	Download
A	binaries/mac_10.6/lib/valgrind/memcheck-x86-darwin	View		Binary file		0 comments	Download
A	binaries/mac_10.6/lib/valgrind/memcheck-x86-darwin.dSYM/Contents/Info.plist	View		1 chunk	+20 lines, -0 lines	0 comments	Download
A	binaries/mac_10.6/lib/valgrind/memcheck-x86-darwin.dSYM/Contents/Resources/DWARF/memcheck-x86-darwin	View		Binary file		0 comments	Download
A	binaries/mac_10.6/lib/valgrind/vgpreload_core-amd64-darwin.so	View		Binary file		0 comments	Download
A	binaries/mac_10.6/lib/valgrind/vgpreload_core-amd64-darwin.so.dSYM/Contents/Info.plist	View		1 chunk	+20 lines, -0 lines	0 comments	Download
A	binaries/mac_10.6/lib/valgrind/vgpreload_core-amd64-darwin.so.dSYM/Contents/Resources/DWARF/vgpreload_core-amd64-darwin.so	View		Binary file		0 comments	Download
A	binaries/mac_10.6/lib/valgrind/vgpreload_core-x86-darwin.so	View		Binary file		0 comments	Download
A	binaries/mac_10.6/lib/valgrind/vgpreload_core-x86-darwin.so.dSYM/Contents/Info.plist	View		1 chunk	+20 lines, -0 lines	0 comments	Download
A	binaries/mac_10.6/lib/valgrind/vgpreload_core-x86-darwin.so.dSYM/Contents/Resources/DWARF/vgpreload_core-x86-darwin.so	View		Binary file		0 comments	Download
A	binaries/mac_10.6/lib/valgrind/vgpreload_memcheck-amd64-darwin.so	View		Binary file		0 comments	Download
A	binaries/mac_10.6/lib/valgrind/vgpreload_memcheck-amd64-darwin.so.dSYM/Contents/Info.plist	View		1 chunk	+20 lines, -0 lines	0 comments	Download
A	binaries/mac_10.6/lib/valgrind/vgpreload_memcheck-amd64-darwin.so.dSYM/Contents/Resources/DWARF/vgpreload_memcheck-amd64-darwin.so	View		Binary file		0 comments	Download
A	binaries/mac_10.6/lib/valgrind/vgpreload_memcheck-x86-darwin.so	View		Binary file		0 comments	Download
A	binaries/mac_10.6/lib/valgrind/vgpreload_memcheck-x86-darwin.so.dSYM/Contents/Info.plist	View		1 chunk	+20 lines, -0 lines	0 comments	Download
A	binaries/mac_10.6/lib/valgrind/vgpreload_memcheck-x86-darwin.so.dSYM/Contents/Resources/DWARF/vgpreload_memcheck-x86-darwin.so	View		Binary file		0 comments	Download
M	scripts/build-memcheck-for-chromium.sh	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	scripts/build-tsan-for-chromium.sh	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	scripts/common.sh	View	1 2	4 chunks	+17 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

On 2010/06/18 10:01:30, Alexander Potapenko wrote: > PTAL

10 years, 6 months ago (2010-06-18 10:11:14 UTC) #2

Timur Iskhodzhanov

LGTM Don't forget to update tools/valgrind/locate_valgrind.sh afterwards

10 years, 6 months ago (2010-06-18 10:12:28 UTC) #3

John Grabowski

10 years, 6 months ago (2010-06-18 17:58:42 UTC) #4

Excellent


On Fri, Jun 18, 2010 at 3:12 AM, <timurrrr@chromium.org> wrote:

> LGTM
> Don't forget to update tools/valgrind/locate_valgrind.sh afterwards
>
>
> http://codereview.chromium.org/2832011/show
>

Expand Messages | Collapse Messages