Fix git cl code to get the changelist description without using gcl....

Fix git cl code to get the changelist description without using gcl.

The git_cl_hooks.py was failing to get the changelist description.
It was using gcl to get the description but this was failing
because gcl was unable to get the cached copy of 
codereview.settings (because it was never set up). In this
case, gcl reverts to the default dictionary which may be 
incorrect in some cases.

This changes to use 'git cl status --field=desc', which
is aware of the codereview.settings.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49878

[tedbo, 2010-06-15 23:21:38]

This is coming from a read-only repository so I can't submit this. I'm looking
for feedback and hopefully one of you two can submit for me if it looks good.

[M-A Ruel, 2010-06-16 00:12:25]

http://codereview.chromium.org/2832006/diff/1/2
File git_cl_hooks.py (right):

http://codereview.chromium.org/2832006/diff/1/2#newcode55
git_cl_hooks.py:55: description = "Missing description."
Don't use tabs in python files!

I'd prefer to have description = ''.

[tedbo, 2010-06-16 00:28:52]

On Tue, Jun 15, 2010 at 5:12 PM,  <maruel@chromium.org> wrote:
>
> http://codereview.chromium.org/2832006/diff/1/2
> File git_cl_hooks.py (right):
>
> http://codereview.chromium.org/2832006/diff/1/2#newcode55
> git_cl_hooks.py:55: description = "Missing description."
> Don't use tabs in python files!

Sorry. I didn't realize that had gotten in there. Fixed.

>
> I'd prefer to have description = ''.

I parse that as empty string? I've changed it to empty string.

Please take another look.

ted

>
> http://codereview.chromium.org/2832006/show
>

[M-A Ruel, 2010-06-16 00:39:36]

lgtm after further simplification

http://codereview.chromium.org/2832006/diff/6001/7001
File git_cl_hooks.py (right):

http://codereview.chromium.org/2832006/diff/6001/7001#newcode54
git_cl_hooks.py:54: if not description:
well, after _reading_ the code, just remove these 2 lines since it's a no-op. :)

[tony, 2010-08-04 22:09:15]

If you delete ~/.codereview_upload_cookies then try to do a git cl upload, you
get what appears to be a hang.  It is actually this call to git cl status
--field=desc waiting on user input for email/password (but you don't see the
prompt because it's happening in a subprocess).

I'm not sure if there's a recent regression or if it's been around for a while. 
It would be nice if we can come up with a way for this to work without having to
prompt the user multiple times.

[M-A Ruel, 2010-10-01 01:00:43]

[Adding Evan]

On 2010/08/04 22:09:15, tony wrote:
> If you delete ~/.codereview_upload_cookies then try to do a git cl upload, you
> get what appears to be a hang.  It is actually this call to git cl status
> --field=desc waiting on user input for email/password (but you don't see the
> prompt because it's happening in a subprocess).
> 
> I'm not sure if there's a recent regression or if it's been around for a
while. 
> It would be nice if we can come up with a way for this to work without having
to
> prompt the user multiple times.

Eh I rediagnosed this problem recently. Someone should fix this eventually. :)

[Mandeep Singh Baines, 2010-10-07 19:05:27]

Following up. This is now fixed:)

On Thu, Sep 30, 2010 at 6:00 PM,  <maruel@chromium.org> wrote:
> [Adding Evan]
>
> On 2010/08/04 22:09:15, tony wrote:
>>
>> If you delete ~/.codereview_upload_cookies then try to do a git cl upload,
>> you
>> get what appears to be a hang.  It is actually this call to git cl status
>> --field=desc waiting on user input for email/password (but you don't see
>> the
>> prompt because it's happening in a subprocess).
>
>> I'm not sure if there's a recent regression or if it's been around for a
>
> while.
>>
>> It would be nice if we can come up with a way for this to work without
>> having
>
> to
>>
>> prompt the user multiple times.
>
> Eh I rediagnosed this problem recently. Someone should fix this eventually.
> :)
>
> http://codereview.chromium.org/2832006/show
>