Add version string in binary and simplify build.

Add version string in binary and simplify build.

[Luigi Semenzato, 2010-06-23 19:54:50]

After talking to Gaurav, I am doing something slightly different for the version
number than what we discussed.  Instead of "make presubmit" this only requires a
"make" in the chroot (or outside, if you have trousers on your machine).  As a
side effect, the make may change the files structures.h and version.h, which are
now in the repository.  Git is good at reminding you to commit any file that has
changed.

[gauravsh, 2010-06-23 20:04:35]

http://codereview.chromium.org/2831027/diff/2001/3001
File src/tlcl/Makefile (right):

http://codereview.chromium.org/2831027/diff/2001/3001#newcode31
src/tlcl/Makefile:31: | sed -e 's/........................//' -e 's/ .*//'>
x.tmp
sed seems overkill here for culling the hash, using 'cut' would be clearer IMO.

http://codereview.chromium.org/2831027/diff/2001/3001#newcode33
src/tlcl/Makefile:33: cmp -s version.tmp version.h || cp version.tmp version.h
can you also echo a reminder here that source files were changed (i know git
warns about this when you commit, but it is useful informative message
nonetheless.

[Luigi Semenzato, 2010-06-23 21:52:22]

On 2010/06/23 20:04:35, gauravsh wrote:
> http://codereview.chromium.org/2831027/diff/2001/3001
> File src/tlcl/Makefile (right):
> 
> http://codereview.chromium.org/2831027/diff/2001/3001#newcode31
> src/tlcl/Makefile:31: | sed -e 's/........................//' -e 's/ .*//'>
> x.tmp
> sed seems overkill here for culling the hash, using 'cut' would be clearer
IMO.
> 
> http://codereview.chromium.org/2831027/diff/2001/3001#newcode33
> src/tlcl/Makefile:33: cmp -s version.tmp version.h || cp version.tmp version.h
> can you also echo a reminder here that source files were changed (i know git
> warns about this when you commit, but it is useful informative message
> nonetheless.


Agree with everything.  PTAL.

[gauravsh, 2010-06-23 22:38:29]

lgtm