Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2831009: Remove the comisd instruction from the ia32 and x64 assemblers. We... (Closed)

Created:
10 years, 6 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

Remove the comisd instruction from the ia32 and x64 assemblers. We should always use ucomisd. Add missing pop from floating-point stack in case of allocation failure. Committed: http://code.google.com/p/v8/source/detail?r=4878

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -33 lines) Patch
M src/ia32/assembler-ia32.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/assembler-ia32.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 5 chunks +8 lines, -4 lines 0 comments Download
M src/x64/assembler-x64.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/x64/codegen-x64.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-disasm-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
10 years, 6 months ago (2010-06-16 12:20:41 UTC) #1
Lasse Reichstein
10 years, 6 months ago (2010-06-16 12:26:55 UTC) #2 
STV!

Powered by Google App Engine
This is Rietveld 408576698