Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 2831004: Managed preferences warning banner for Mac preferences dialog (Closed)

Created:
10 years, 6 months ago by Mattias Nissler (ping if slow)
Modified:
9 years, 7 months ago
CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Managed preferences warning banner for Mac preferences dialog Add a new view to the preferences dialog in Preferences.xib that holds the alert image and the warning message label. Update the visibility of the warning banner when switching preference views in PreferencesWindowController. BUG=43423 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50444

Patch Set 1 #

Total comments: 12

Patch Set 2 : Incorporate feedback. #

Total comments: 6

Patch Set 3 : Generic background gradient view. #

Total comments: 20

Patch Set 4 : rebase, take care of comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+466 lines, -88 lines) Patch
M chrome/app/nibs/Preferences.xib View 1 2 12 chunks +156 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/infobar_gradient_view.h View 1 chunk +3 lines, -8 lines 0 comments Download
M chrome/browser/cocoa/infobar_gradient_view.mm View 3 chunks +7 lines, -23 lines 0 comments Download
M chrome/browser/cocoa/preferences_window_controller.h View 1 2 3 3 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/preferences_window_controller.mm View 1 2 3 11 chunks +188 lines, -55 lines 0 comments Download
A chrome/browser/cocoa/vertical_gradient_view.h View 3 1 chunk +35 lines, -0 lines 0 comments Download
A chrome/browser/cocoa/vertical_gradient_view.mm View 3 1 chunk +39 lines, -0 lines 0 comments Download
A chrome/browser/cocoa/vertical_gradient_view_unittest.mm View 1 chunk +27 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Mattias Nissler (ping if slow)
Mike, would you mind reviewing this? And please bear with me, this is my first ...
10 years, 6 months ago (2010-06-15 17:02:47 UTC) #1
Avi (use Gerrit)
The bug number is most certainly wrong; please double-check it.
10 years, 6 months ago (2010-06-15 17:05:55 UTC) #2
Mattias Nissler (ping if slow)
On 2010/06/15 17:05:55, Avi wrote: > The bug number is most certainly wrong; please double-check ...
10 years, 6 months ago (2010-06-15 17:17:49 UTC) #3
pink (ping after 24hrs)
http://codereview.chromium.org/2831004/diff/1/4 File chrome/browser/cocoa/managed_prefs_banner_gradient_view.mm (right): http://codereview.chromium.org/2831004/diff/1/4#newcode27 chrome/browser/cocoa/managed_prefs_banner_gradient_view.mm:27: NSGradient* gradient = this is leaked. Use scoped_nsobject. http://codereview.chromium.org/2831004/diff/1/6 ...
10 years, 6 months ago (2010-06-15 18:53:08 UTC) #4
Mattias Nissler (ping if slow)
Thanks for your feedback, Mike. Here's an updated version. http://codereview.chromium.org/2831004/diff/1/4 File chrome/browser/cocoa/managed_prefs_banner_gradient_view.mm (right): http://codereview.chromium.org/2831004/diff/1/4#newcode27 chrome/browser/cocoa/managed_prefs_banner_gradient_view.mm:27: ...
10 years, 6 months ago (2010-06-16 11:16:04 UTC) #5
pink (ping after 24hrs)
http://codereview.chromium.org/2831004/diff/1007/9003 File chrome/browser/cocoa/managed_prefs_banner_gradient_view.mm (right): http://codereview.chromium.org/2831004/diff/1007/9003#newcode15 chrome/browser/cocoa/managed_prefs_banner_gradient_view.mm:15: @implementation ManagedPrefsBannerGradientView This seems like it could be made ...
10 years, 6 months ago (2010-06-16 14:55:31 UTC) #6
Mattias Nissler (ping if slow)
Thanks Mike for your comments, here's the next iteration. http://codereview.chromium.org/2831004/diff/1007/9003 File chrome/browser/cocoa/managed_prefs_banner_gradient_view.mm (right): http://codereview.chromium.org/2831004/diff/1007/9003#newcode15 chrome/browser/cocoa/managed_prefs_banner_gradient_view.mm:15: ...
10 years, 6 months ago (2010-06-18 11:01:20 UTC) #7
pink (ping after 24hrs)
http://codereview.chromium.org/2831004/diff/15001/16004 File chrome/browser/cocoa/preferences_window_controller.h (right): http://codereview.chromium.org/2831004/diff/15001/16004#newcode9 chrome/browser/cocoa/preferences_window_controller.h:9: #import "chrome/browser/cocoa/vertical_gradient_view.h" i don't think you need this include ...
10 years, 6 months ago (2010-06-18 19:46:56 UTC) #8
Mattias Nissler (ping if slow)
Mike, sorry for all the poor style in the last incarnation. Here's an updated version. ...
10 years, 6 months ago (2010-06-21 18:42:28 UTC) #9
pink (ping after 24hrs)
10 years, 6 months ago (2010-06-21 18:51:59 UTC) #10
lgtm. thanks!

Powered by Google App Engine
This is Rietveld 408576698