Issue 28310: Fixes Issue 7377: Regression: Omnibox trims URL ending with 0x85 (Take 2)...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 28310: Fixes Issue 7377: Regression: Omnibox trims URL ending with 0x85 (Take 2)... (Closed)

Created:
11 years, 9 months ago by Hironori Bono

Modified:
9 years, 7 months ago

Reviewers:
jungshik at Google

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fixes Issue 7377: Regression: Omnibox trims URL ending with 0x85 (Take 2) This is the same change as "http://codereview.chromium.org/20219/show", which I reverted it because it caused build breaks on sandbox. To investigate this build break, it seems this build break is somehow caused by "base/string_util.cc" that includes the TrimWhiteSpaceUTF8() function. To fix this build break, I moved the TrimWhiteSpaceUTF8() function to "base/string_util_icu.cc". BUG=7377 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10970

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+106 lines, -8 lines)			Patch
M	base/string_util.h	View		2 chunks	+16 lines, -3 lines	0 comments	Download
M	base/string_util.cc	View	1	2 chunks	+9 lines, -3 lines	0 comments	Download
M	base/string_util_icu.cc	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	base/string_util_unittest.cc	View		2 chunks	+46 lines, -1 line	0 comments	Download
M	chrome/browser/net/url_fixer_upper.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/net/url_fixer_upper_unittest.cc	View		1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jungshik at Google

11 years, 9 months ago (2009-03-03 18:44:29 UTC) #2

lgtm.

it's strange, though, that this led to a build in sandbox.

Expand Messages | Collapse Messages