third_party/libevent/README.chromium - Issue 28305: GYP it, GYP it good

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/libevent/README.chromium

Issue 28305: GYP it, GYP it good (Closed) Base URL: svn://chrome-svn.corp.google.com/chrome/trunk/src/

Patch Set: Created 11 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« DEPS ('K') | « third_party/bzip2/bzip2.xcodeproj/project.pbxproj ('k') | third_party/libevent/libevent.xcodeproj/libevent_prebuild.sh » ('j') | no next file with comments »

OLD	NEW
1 This contains a copy of libevent-1.4.7-stable for use on Linux and Mac	1 This contains a copy of libevent-1.4.7-stable for use on Linux and Mac

2	2

3 Rather than use libevent's own build system, we just build a Chrome	3 Rather than use libevent's own build system, we just build a Chrome

4 static library using SConscript	4 static library using SConscript

5	5

6 Changes from upstream:	6 Changes from upstream:

7 1) add linux/config.h from a run of configure on a Linux development box.	7 1) add linux/config.h from a run of configure on a Linux development box.

8 2) add SConscript and libevent.xcodeproj	8 2) add SConscript and libevent.gyp

9 3) quotes.patch is applied to allow libevent to be used without	9 3) quotes.patch is applied to allow libevent to be used without

10 being installed (alternative is adding crazy -I arguments to the commandline)	10 being installed (alternative is adding crazy -I arguments to the commandline)

11 4) The directories WIN32-Code and WIN32-Prj are not included	11 4) The directories WIN32-Code and WIN32-Prj are not included

12 5) add mac/config.h from a run of configure on a Mac.	12 5) add mac/config.h from a run of configure on a Mac.

13	13

14 SConscript does not include a few files that don't build on Linux:	14 SConscript does not include a few files that don't build on Linux:

15 devpoll.c, evport.c, kqueue.c	15 devpoll.c, evport.c, kqueue.c

16 libevent.xcodeproj does not include a few files that don't build on the Mac:

17 devpoll.c, epoll.c, epoll_sub.c, evport.c

18	16

19 TODO: currently we -I the source directory, which exposes event-config.h, which	17 TODO: currently we -I the source directory, which exposes event-config.h, which

20 is dangerous as this file was generated for Linux and is not entirely correct on	18 is dangerous as this file was generated for Linux and is not entirely correct on

21 other platforms.	19 other platforms.

OLD	NEW