Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 28305: GYP it, GYP it good (Closed)

Created:
11 years, 9 months ago by Mark Mentovai
Modified:
9 years, 7 months ago
Reviewers:
TVL, bradn
CC:
chromium-reviews_googlegroups.com
Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/
Visibility:
Public.

Description

GYP it, GYP it good. Convert the Mac build to the new GYP-based Xcode build, and remove the old Xcode projects. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10693

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -26337 lines) Patch
M DEPS View 2 chunks +10 lines, -2 lines 1 comment Download
D base/base.xcodeproj/project.pbxproj View 1 chunk +0 lines, -1893 lines 0 comments Download
D build/all.xcodeproj/project.pbxproj View 1 chunk +0 lines, -1793 lines 0 comments Download
M build/common.gypi View 1 chunk +1 line, -6 lines 0 comments Download
D build/googleurl.xcodeproj/project.pbxproj View 1 chunk +0 lines, -811 lines 0 comments Download
D build/v8.xcodeproj/project.pbxproj View 1 chunk +0 lines, -1392 lines 0 comments Download
D build/v8.xcodeproj/v8-arm_prebuild.sh View 1 chunk +0 lines, -59 lines 0 comments Download
D build/v8.xcodeproj/v8_prebuild.sh View 1 chunk +0 lines, -60 lines 0 comments Download
D chrome/chrome.xcodeproj/generate_headers.sh View 1 chunk +0 lines, -90 lines 0 comments Download
D chrome/chrome.xcodeproj/project.pbxproj View 1 chunk +0 lines, -7356 lines 0 comments Download
D chrome/third_party/hunspell/hunspell.xcodeproj/project.pbxproj View 1 chunk +0 lines, -307 lines 0 comments Download
D media/media.xcodeproj/project.pbxproj View 1 chunk +0 lines, -878 lines 0 comments Download
D net/net.xcodeproj/project.pbxproj View 1 chunk +0 lines, -2018 lines 0 comments Download
D printing/printing.xcodeproj/project.pbxproj View 1 chunk +0 lines, -728 lines 0 comments Download
D sdch/sdch.xcodeproj/project.pbxproj View 1 chunk +0 lines, -249 lines 0 comments Download
D sdch/sdch.xcodeproj/sdch_prebuild.sh View 1 chunk +0 lines, -59 lines 0 comments Download
D skia/skia.xcodeproj/project.pbxproj View 1 chunk +0 lines, -1186 lines 0 comments Download
D testing/gtest.xcodeproj/project.pbxproj View 1 chunk +0 lines, -220 lines 0 comments Download
D third_party/bzip2/bzip2.xcodeproj/project.pbxproj View 1 chunk +0 lines, -213 lines 0 comments Download
M third_party/libevent/README.chromium View 2 chunks +1 line, -3 lines 0 comments Download
D third_party/libevent/libevent.xcodeproj/libevent_prebuild.sh View 1 chunk +0 lines, -91 lines 0 comments Download
D third_party/libevent/libevent.xcodeproj/project.pbxproj View 1 chunk +0 lines, -272 lines 0 comments Download
D third_party/libjpeg/libjpeg.xcodeproj/project.pbxproj View 1 chunk +0 lines, -373 lines 0 comments Download
D third_party/libpng/libpng.xcodeproj/project.pbxproj View 1 chunk +0 lines, -249 lines 0 comments Download
D third_party/libxml/libxml.xcodeproj/libxml_config_prebuild.sh View 1 chunk +0 lines, -149 lines 0 comments Download
D third_party/libxml/libxml.xcodeproj/project.pbxproj View 1 chunk +0 lines, -1077 lines 0 comments Download
D third_party/libxslt/libxslt.xcodeproj/libxslt_config_prebuild.sh View 1 chunk +0 lines, -73 lines 0 comments Download
D third_party/libxslt/libxslt.xcodeproj/project.pbxproj View 1 chunk +0 lines, -432 lines 0 comments Download
D third_party/lzma_sdk/lzma_sdk.xcodeproj/project.pbxproj View 1 chunk +0 lines, -286 lines 0 comments Download
D third_party/modp_b64/modp_b64.xcodeproj/project.pbxproj View 1 chunk +0 lines, -183 lines 0 comments Download
D third_party/sqlite/sqlite.xcodeproj/project.pbxproj View 1 chunk +0 lines, -547 lines 0 comments Download
D third_party/zlib/zlib.xcodeproj/project.pbxproj View 1 chunk +0 lines, -265 lines 0 comments Download
D webkit/tools/npapi_layout_test_plugin/npapi_layout_test_plugin.xcodeproj/project.pbxproj View 1 chunk +0 lines, -258 lines 0 comments Download
D webkit/tools/test_shell/mac/TestShell.xcodeproj/package_test_shell.sh View 1 chunk +0 lines, -76 lines 0 comments Download
D webkit/tools/test_shell/mac/TestShell.xcodeproj/project.pbxproj View 1 chunk +0 lines, -2526 lines 0 comments Download
D webkit/webkit.xcodeproj/glue_prebuild.sh View 1 chunk +0 lines, -28 lines 0 comments Download
D webkit/webkit.xcodeproj/jsbindings_prebuild.sh View 1 chunk +0 lines, -56 lines 0 comments Download
D webkit/webkit.xcodeproj/jsconfig_prebuild.sh View 1 chunk +0 lines, -11 lines 0 comments Download
D webkit/webkit.xcodeproj/pcre_prebuild.sh View 1 chunk +0 lines, -14 lines 0 comments Download
D webkit/webkit.xcodeproj/webcore_prebuild.sh View 1 chunk +0 lines, -34 lines 0 comments Download
D webkit/webkit.xcodeproj/webcoresysteminterface_prebuild.sh View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Mentovai
TBR (Mac GYP migration) The only interesting bit here is the DEPS file. For the ...
11 years, 9 months ago (2009-03-02 00:18:13 UTC) #1
TVL
lgtm http://codereview.chromium.org/28305/diff/1/1033 File DEPS (right): http://codereview.chromium.org/28305/diff/1/1033#newcode96 Line 96: "action": ["python", "src/tools/gyp/gyp_dogfood", "src/build/all.gyp"], why _dogfood?
11 years, 9 months ago (2009-03-02 02:17:15 UTC) #2
bradn
11 years, 9 months ago (2009-03-02 06:56:11 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698