Advanced (Under the Hood) options panel code review

chrome/browser/dom_ui/core_options_handler.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/dom_ui/core_options_handler.h"
 
 #include "app/l10n_util.h"
 #include "app/resource_bundle.h"
 #include "base/utf_string_conversions.h"
 #include "base/values.h"
@@ skipping 26 matching lines @@
 }
 
 void CoreOptionsHandler::GetLocalizedValues(
     DictionaryValue* localized_strings) {
   DCHECK(localized_strings);
   // Main
   localized_strings->SetString(L"title",
       l10n_util::GetStringF(IDS_OPTIONS_DIALOG_TITLE,
           l10n_util::GetString(IDS_PRODUCT_NAME)));
 
+  localized_strings->SetString(L"browserPage",
+      l10n_util::GetString(IDS_OPTIONS_GENERAL_TAB_LABEL));
+  localized_strings->SetString(L"personalPage",
+      l10n_util::GetString(IDS_OPTIONS_CONTENT_TAB_LABEL));
+  localized_strings->SetString(L"advancedPage",
+      l10n_util::GetString(IDS_OPTIONS_ADVANCED_TAB_LABEL));
 #if defined(OS_CHROMEOS)
   localized_strings->SetString(L"internetPage",
       l10n_util::GetString(IDS_OPTIONS_INTERNET_TAB_LABEL));
 #endif
-
-  localized_strings->SetString(L"basicsPage",
-      l10n_util::GetString(IDS_OPTIONS_GENERAL_TAB_LABEL));
-  localized_strings->SetString(L"personalStuffPage",
-      l10n_util::GetString(IDS_OPTIONS_CONTENT_TAB_LABEL));
-  localized_strings->SetString(L"underHoodPage",
-      l10n_util::GetString(IDS_OPTIONS_ADVANCED_TAB_LABEL));
 }
 
 void CoreOptionsHandler::Observe(NotificationType type,
                                  const NotificationSource& source,
                                  const NotificationDetails& details) {
   if (type == NotificationType::PREF_CHANGED)
     NotifyPrefChanged(Details<std::wstring>(details).ptr());
 }
 
 void CoreOptionsHandler::RegisterMessages() {
@@ skipping 167 matching lines @@
         pref_callback_map_.find(*pref_name);
         iter != pref_callback_map_.end(); ++iter) {
       const std::wstring& callback_function = iter->second;
       ListValue result_value;
       result_value.Append(Value::CreateStringValue(pref_name->c_str()));
       result_value.Append(pref->GetValue()->DeepCopy());
       dom_ui_->CallJavascriptFunction(callback_function, result_value);
     }
   }
 }