Issue 2830035: tc_malloc_usable_size impl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2830035: tc_malloc_usable_size impl (Closed)

Created:
10 years, 5 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
Patrick Horn, willchan no longer on Chromium

CC:
chromium-reviews

Visibility:
Public.

Description

tcmalloc: also hook malloc_usable_size The nvidia opengl driver uses this function. If we don't hook it with tcmalloc, then we mix calls to tcmalloc functions (malloc, free, etc) with the libc ones, causing our WebGL bits to hang. BUG=44590 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51539

Patch Set 1 #

Patch Set 2 : ok #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	third_party/tcmalloc/chromium/src/tcmalloc.cc	View		3 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

(since i can't repro the problem, i dunno if this fixes it. feedback welcome.)

10 years, 5 months ago (2010-07-02 00:17:33 UTC) #2

Patrick Horn

On 2010/07/02 00:17:33, Evan Martin wrote: > (since i can't repro the problem, i dunno ...

10 years, 5 months ago (2010-07-02 01:04:36 UTC) #3

willchan no longer on Chromium

10 years, 5 months ago (2010-07-02 13:41:48 UTC) #4

LGTM.  I'll look into upstreaming this after I get back from my leave.

Expand Messages | Collapse Messages