Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2830005: Rename browser_accessibility to browser_accessibility_win, and same for... (Closed)

Created:
10 years, 6 months ago by dmazzoni
Modified:
9 years, 7 months ago
CC:
chromium-reviews, jam+cc_chromium.org, brettw-cc_chromium.org, ben+cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., David Tseng
Visibility:
Public.

Description

Rename browser_accessibility to browser_accessibility_win, and same for browser_accessibility_manager, to make it more clear that these are Windows-only source files. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49947

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1819 lines) Patch
D chrome/browser/browser_accessibility.h View 1 2 1 chunk +0 lines, -399 lines 0 comments Download
D chrome/browser/browser_accessibility.cc View 1 2 1 chunk +0 lines, -1013 lines 0 comments Download
D chrome/browser/browser_accessibility_manager.h View 1 2 1 chunk +0 lines, -120 lines 0 comments Download
D chrome/browser/browser_accessibility_manager.cc View 1 2 1 chunk +0 lines, -151 lines 0 comments Download
A + chrome/browser/browser_accessibility_manager_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/browser_accessibility_manager_win.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/browser/browser_accessibility_unittest.cc View 1 2 1 chunk +0 lines, -111 lines 0 comments Download
A + chrome/browser/browser_accessibility_win.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/browser_accessibility_win.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/browser_accessibility_win_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_win.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_win.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dmazzoni
10 years, 6 months ago (2010-06-15 16:45:10 UTC) #1
Chris Guillory
Looks like you need to add chrome_tests.gypi and chrome_browser.gypi to the change.
10 years, 6 months ago (2010-06-15 17:38:15 UTC) #2
dmazzoni
Oops! Thanks, uploaded again with those files. On Tue, Jun 15, 2010 at 10:38 AM, ...
10 years, 6 months ago (2010-06-15 17:52:27 UTC) #3
James Hawkins
LGTM!
10 years, 6 months ago (2010-06-15 18:06:15 UTC) #4
Chris Guillory
10 years, 6 months ago (2010-06-15 18:25:09 UTC) #5 
LGTM

Powered by Google App Engine
This is Rietveld 408576698