Issue 28296: Simplify the way that we compile slow-case switch statements. Compile...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 28296: Simplify the way that we compile slow-case switch statements. Compile... (Closed)

Created:
11 years, 10 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
iposva, William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Simplify the way that we compile slow-case switch statements. Compile all the reachable tests first, and then all the reachable bodies. Committed: http://code.google.com/p/v8/source/detail?r=1397

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -156 lines)			Patch
	M	src/ast.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	src/codegen-ia32.cc	View	1 2	1 chunk	+70 lines, -156 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

iposva

11 years, 9 months ago (2009-03-02 10:16:20 UTC) #2

Small comments as discussed, otherwise LGTM.

-Ivan

http://codereview.chromium.org/28296/diff/12/14
File src/codegen-ia32.cc (right):

http://codereview.chromium.org/28296/diff/12/14#newcode2103
Line 2103: // Compile case bodies as needed.
ASSERT that you do not have a valid frame here and comment why this is so.

http://codereview.chromium.org/28296/diff/12/14#newcode2132
Line 2132: }
Add else case here for the only fall-through case with an ASSERT.

Expand Messages | Collapse Messages