Issue 2829042: Fix a fts3 typo/bug.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2829042: Fix a fts3 typo/bug. (Closed)

Created:
10 years, 5 months ago by dumi

Modified:
9 years, 7 months ago

Reviewers:
Scott Hess - ex-Googler

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix a fts3 typo/bug. TEST=crash doesn't seem to happen anymore BUG=47059 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51584

Patch Set 1 #

Total comments: 1

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	third_party/sqlite/ext/fts3/fts3.c	View		1 chunk	+1 line, -1 line	1 comment	Download
	M	third_party/sqlite/fts3.patch	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Scott Hess - ex-Googler

LGTM http://codereview.chromium.org/2829042/diff/1/2 File third_party/sqlite/ext/fts3/fts3.c (right): http://codereview.chromium.org/2829042/diff/1/2#newcode4720 third_party/sqlite/ext/fts3/fts3.c:4720: n = fts3GetVarint32Safe(pReader->pData, &nSuffix, pReader->nData); I believe I ...

10 years, 5 months ago (2010-07-03 01:37:26 UTC) #1

dumi

10 years, 5 months ago (2010-07-03 01:39:32 UTC) #2

On 2010/07/03 01:37:26, shess wrote:
> LGTM
> 
> http://codereview.chromium.org/2829042/diff/1/2
> File third_party/sqlite/ext/fts3/fts3.c (right):
> 
> http://codereview.chromium.org/2829042/diff/1/2#newcode4720
> third_party/sqlite/ext/fts3/fts3.c:4720: n =
fts3GetVarint32Safe(pReader->pData,
> &nSuffix, pReader->nData);
> I believe I complained about that exact line of code ... except it was a
problem
> with the pData reference.  Gah!

nor your fault, i should've taken a more thorough look at the patch/diffs before
submitting it.

Expand Messages | Collapse Messages