[PATCH 3/5] Unify efi and legacy bootloader configuration generation

[PATCH 3/5] Unify efi and legacy bootloader configuration generation

This change unifies the creation of extlinux.conf,
syslinux cfgs, and grub efi files.  It shouldn't change the
existing behavior but does add support for further arguments
and future use of syslinux (once it is properly rewritten by
an installer or other script).

TEST=in progress; manual run
BUG=chromium-os:327

[adlr, 2010-07-02 19:36:36]

LGTM

http://codereview.chromium.org/2829038/diff/1/3
File create_legacy_bootloader_templates.sh (right):

http://codereview.chromium.org/2829038/diff/1/3#newcode109
create_legacy_bootloader_templates.sh:109: append quiet console=tty2
init=/sbin/init boot=local rootwait root=${FLAGS_usb_disk} ro noresume noswap
i915.modeset=1 loglevel=1
can you put common args in a variable or something to avoid duplication?

http://codereview.chromium.org/2829038/diff/1/3#newcode118
create_legacy_bootloader_templates.sh:118: # Different files are used so that
the updater can only touch the file it needs
80 cols

[Will Drewry, 2010-07-02 19:52:03]

http://codereview.chromium.org/2829038/diff/1/3
File create_legacy_bootloader_templates.sh (right):

http://codereview.chromium.org/2829038/diff/1/3#newcode109
create_legacy_bootloader_templates.sh:109: append quiet console=tty2
init=/sbin/init boot=local rootwait root=${FLAGS_usb_disk} ro noresume noswap
i915.modeset=1 loglevel=1
On 2010/07/02 19:36:36, adlr wrote:
> can you put common args in a variable or something to avoid duplication?

Done.

http://codereview.chromium.org/2829038/diff/1/3#newcode118
create_legacy_bootloader_templates.sh:118: # Different files are used so that
the updater can only touch the file it needs
On 2010/07/02 19:36:36, adlr wrote:
> 80 cols

Done.

[adlr, 2010-07-02 19:53:47]

LGTM thanks