Add test to check for unused config values in ibus

Add test to check for unused config values in ibus

BUG=chromium-os:3672
TEST=Run desktopui_IBusTest via autotest.

[satorux1, 2010-06-26 03:46:48]

Thank you for adding the test!

http://codereview.chromium.org/2829023/diff/7001/8001
File client/deps/ibusclient/src/ibusclient.cc (right):

http://codereview.chromium.org/2829023/diff/7001/8001#newcode206
client/deps/ibusclient/src/ibusclient.cc:206: bool PrintArray(GValue* gvalue) {
Please add a function comment. This returns true on success right?

http://codereview.chromium.org/2829023/diff/7001/8001#newcode225
client/deps/ibusclient/src/ibusclient.cc:225: void PrintUnused(IBusConfig*
ibus_config) {
Please write a function comment.

http://codereview.chromium.org/2829023/diff/7001/8001#newcode262
client/deps/ibusclient/src/ibusclient.cc:262: void
PreloadEnginesAndPrintResult(IBusConfig* ibus_config, int count,
count -> num_engines ?

http://codereview.chromium.org/2829023/diff/7001/8001#newcode264
client/deps/ibusclient/src/ibusclient.cc:264: GValue gvalue = { 0 };
{0} to be consistent with other places?

http://codereview.chromium.org/2829023/diff/7001/8002
File client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py (right):

http://codereview.chromium.org/2829023/diff/7001/8002#newcode78
client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py:78: def
test_unused(self):
test_unused may be a bit cryptic. could you give it a bit more descriptive name?

[Zachary Kuznia, 2010-06-28 02:31:51]

http://codereview.chromium.org/2829023/diff/7001/8001
File client/deps/ibusclient/src/ibusclient.cc (right):

http://codereview.chromium.org/2829023/diff/7001/8001#newcode206
client/deps/ibusclient/src/ibusclient.cc:206: bool PrintArray(GValue* gvalue) {
On 2010/06/26 03:46:48, satorux1 wrote:
> Please add a function comment. This returns true on success right?

Done.

http://codereview.chromium.org/2829023/diff/7001/8001#newcode225
client/deps/ibusclient/src/ibusclient.cc:225: void PrintUnused(IBusConfig*
ibus_config) {
On 2010/06/26 03:46:48, satorux1 wrote:
> Please write a function comment.

Done.

http://codereview.chromium.org/2829023/diff/7001/8001#newcode262
client/deps/ibusclient/src/ibusclient.cc:262: void
PreloadEnginesAndPrintResult(IBusConfig* ibus_config, int count,
On 2010/06/26 03:46:48, satorux1 wrote:
> count -> num_engines ?

Done.

http://codereview.chromium.org/2829023/diff/7001/8001#newcode264
client/deps/ibusclient/src/ibusclient.cc:264: GValue gvalue = { 0 };
On 2010/06/26 03:46:48, satorux1 wrote:
> {0} to be consistent with other places?

Done.

http://codereview.chromium.org/2829023/diff/7001/8002
File client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py (right):

http://codereview.chromium.org/2829023/diff/7001/8002#newcode78
client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py:78: def
test_unused(self):
On 2010/06/26 03:46:48, satorux1 wrote:
> test_unused may be a bit cryptic. could you give it a bit more descriptive
name?

Done.

[satorux1, 2010-06-28 02:47:35]

LGTM

http://codereview.chromium.org/2829023/diff/14001/15001
File client/deps/ibusclient/src/ibusclient.cc (right):

http://codereview.chromium.org/2829023/diff/14001/15001#newcode208
client/deps/ibusclient/src/ibusclient.cc:208: // On failure, prints out "FAIL
(error message)" instead.
Could you also write about the return value?

http://codereview.chromium.org/2829023/diff/14001/15001#newcode267
client/deps/ibusclient/src/ibusclient.cc:267: void
PreloadEnginesAndPrintResult(IBusConfig* ibus_config, int num_engines,
function comment.

http://codereview.chromium.org/2829023/diff/14001/15001#newcode268
client/deps/ibusclient/src/ibusclient.cc:268: char** engines) {
add const?

const char* engines[]

http://codereview.chromium.org/2829023/diff/14001/15001#newcode290
client/deps/ibusclient/src/ibusclient.cc:290: void
ActivateEngineAndPrintResult(IBusBus* ibus, const char* engine_name) {
ditto.

[Zachary Kuznia, 2010-06-29 01:23:58]

http://codereview.chromium.org/2829023/diff/14001/15001
File client/deps/ibusclient/src/ibusclient.cc (right):

http://codereview.chromium.org/2829023/diff/14001/15001#newcode267
client/deps/ibusclient/src/ibusclient.cc:267: void
PreloadEnginesAndPrintResult(IBusConfig* ibus_config, int num_engines,
On 2010/06/28 02:47:36, satorux1 wrote:
> function comment.

Done.

http://codereview.chromium.org/2829023/diff/14001/15001#newcode268
client/deps/ibusclient/src/ibusclient.cc:268: char** engines) {
On 2010/06/28 02:47:36, satorux1 wrote:
> add const?
> 
> const char* engines[] 

Adding the const here would require a static_cast to match in main()

http://codereview.chromium.org/2829023/diff/14001/15001#newcode290
client/deps/ibusclient/src/ibusclient.cc:290: void
ActivateEngineAndPrintResult(IBusBus* ibus, const char* engine_name) {
On 2010/06/28 02:47:36, satorux1 wrote:
> ditto.

Done.