Issue 2829020: Add regression test for the code flushing in issue 474 (which was...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2829020: Add regression test for the code flushing in issue 474 (which was... (Closed)

Created:
10 years, 6 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add regression test for the code flushing in issue 474 (which was fixed in revision 4921). This also enables codeflushing by default. Committed: http://code.google.com/p/v8/source/detail?r=4922

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -1 line)			Patch
	M	src/flag-definitions.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	A	test/mjsunit/regress/regress-747.js	View	1	1 chunk	+56 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Rico

Small addition to last commit, including a regression test.

10 years, 6 months ago (2010-06-23 07:40:44 UTC) #1

Kasper Lund

10 years, 6 months ago (2010-06-23 07:48:27 UTC) #2

LGTM.

http://codereview.chromium.org/2829020/diff/1/3
File test/mjsunit/regress/regress-747.js (right):

http://codereview.chromium.org/2829020/diff/1/3#newcode39
test/mjsunit/regress/regress-747.js:39: try{
Space after try.

http://codereview.chromium.org/2829020/diff/1/3#newcode52
test/mjsunit/regress/regress-747.js:52: try{
Space after try.

Expand Messages | Collapse Messages