Issue 2829003: Support OS X in coverity.py. Avoid echoing coverity password to console.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2829003: Support OS X in coverity.py. Avoid echoing coverity password to console. (Closed)

Created:
10 years, 6 months ago by jimhebert

Modified:
9 years, 7 months ago

Reviewers:
bevc, wtc

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Support OS X in coverity.py. Avoid echoing coverity password to console. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49976

Patch Set 1 #

Total comments: 1

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -3 lines)			Patch
	M	tools/coverity/coverity.py	View		4 chunks	+16 lines, -3 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

wtc

LGTM. Thanks! http://codereview.chromium.org/2829003/diff/1/2 File tools/coverity/coverity.py (right): http://codereview.chromium.org/2829003/diff/1/2#newcode207 tools/coverity/coverity.py:207: # Avoid echoing the Commit command because ...

10 years, 6 months ago (2010-06-15 22:04:07 UTC) #1

jimhebert

10 years, 6 months ago (2010-06-15 22:29:06 UTC) #2

On Tue, Jun 15, 2010 at 3:04 PM, <wtc@chromium.org> wrote:

> Can we tell cov-commit-defects to read the password from a
> file?  That'll also solve the command echoing problem.
>
>
For whatever it's worth, cov-commit-defects does not provide the option to
do so.

Thanks for the review!

Expand Messages | Collapse Messages