Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 28281: Get rid of wstring variants of StringToFoo. (Closed)

Created:
11 years, 9 months ago by dsh
Modified:
7 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Get rid of wstring variants of StringToFoo. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10664

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -91 lines) Patch
M base/json_reader.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M base/string_util.h View 2 chunks +9 lines, -9 lines 0 comments Download
M base/string_util.cc View 1 13 chunks +57 lines, -27 lines 0 comments Download
M base/string_util_unittest.cc View 1 9 chunks +19 lines, -13 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_codec.cc View 2 chunks +4 lines, -2 lines 1 comment Download
M chrome/browser/bookmarks/bookmark_html_writer.cc View 1 chunk +2 lines, -1 line 1 comment Download
M chrome/browser/browser_init.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/dom_ui/dom_ui.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/dom_ui/history_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/new_tab_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/text_database.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/metrics/metrics_service.cc View 1 chunk +6 lines, -3 lines 1 comment Download
M chrome/browser/page_state.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/search_engines/template_url_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_parser.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/common/logging_chrome.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/common/pref_service.cc View 2 chunks +4 lines, -3 lines 1 comment Download
M chrome/test/ui/ui_test.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/test/ui/ui_test_suite.h View 2 chunks +1 line, -2 lines 0 comments Download
M webkit/glue/dom_operations.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/node_leak_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_main.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
dsh
Since the types are the same on Windows, there still are surely a lot of ...
11 years, 9 months ago (2009-02-27 23:23:56 UTC) #1
brettw
11 years, 9 months ago (2009-02-27 23:45:15 UTC) #2
LGTM

http://codereview.chromium.org/28281/diff/36/51
File chrome/browser/bookmarks/bookmark_codec.cc (right):

http://codereview.chromium.org/28281/diff/36/51#newcode180
Line 180: WideToUTF16Hack(last_modified_date)));
Don't wrap 4 spaces from random parts of the line. I would move
Time::FromInternalValue to the previous line and wrap the other args to 4 spaces
(same below).

http://codereview.chromium.org/28281/diff/36/52
File chrome/browser/bookmarks/bookmark_html_writer.cc (right):

http://codereview.chromium.org/28281/diff/36/52#newcode197
Line 197: base::Time::FromInternalValue(StringToInt64(WideToUTF16Hack(
See prev comment.

http://codereview.chromium.org/28281/diff/36/46
File chrome/browser/metrics/metrics_service.cc (right):

http://codereview.chromium.org/28281/diff/36/46#newcode623
Line 623: StringToInt64(WideToUTF16Hack(pref->GetString(
See previous comment.

http://codereview.chromium.org/28281/diff/36/57
File chrome/common/pref_service.cc (right):

http://codereview.chromium.org/28281/diff/36/57#newcode76
Line 76: resource_string)));
I'd wrap this and the next change to 4 spaces from the beginning of the line.

Powered by Google App Engine
This is Rietveld 408576698