Issue 2828017: Update libmetrics docs to cover some recent questions and issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2828017: Update libmetrics docs to cover some recent questions and issues. (Closed)

Created:
10 years, 6 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
Sam Leffler, sosa

CC:
chromium-os-reviews_chromium.org, Luigi Semenzato, sosa

Base URL:
ssh://git@chromiumos-git/metrics.git

Visibility:
Public.

Description

Update libmetrics docs to cover some recent questions and issues.

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -0 lines)			Patch
	M	README	View		1 chunk	+33 lines, -0 lines	0 comments	Download
	M	metrics_library.h	View		2 chunks	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Sam Leffler

LGTM; not sure if it's worth putting a sanity check in the library to guard ...

10 years, 6 months ago (2010-06-21 23:01:08 UTC) #3

petkov

10 years, 6 months ago (2010-06-21 23:26:44 UTC) #4

On 2010/06/21 23:01:08, Sam Leffler wrote:
> LGTM; not sure if it's worth putting a sanity check in the library to guard
> against huge mallocs like I made.

Yeah, maybe (separate CL). Although it seems that these checks might belong to
Chrome because it is Chrome that fails.

Expand Messages | Collapse Messages