Issue 2828004: ARM: Remove a bunch of spilled scopes. Still a lot to go.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2828004: ARM: Remove a bunch of spilled scopes. Still a lot to go. (Closed)

Created:
10 years, 6 months ago by Erik Corry

Modified:
10 years, 6 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

ARM: Remove a bunch of spilled scopes. Still a lot to go. Committed: http://code.google.com/p/v8/source/detail?r=4932

Patch Set 1 #

Total comments: 4

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+214 lines, -143 lines)			Patch
M	src/arm/codegen-arm.cc	View	57 chunks	+130 lines, -140 lines	3 comments	Download
M	src/arm/jump-target-arm.cc	View	3 chunks	+16 lines, -0 lines	0 comments	Download
M	src/arm/virtual-frame-arm.h	View	4 chunks	+11 lines, -2 lines	1 comment	Download
M	src/arm/virtual-frame-arm.cc	View	2 chunks	+44 lines, -0 lines	0 comments	Download
M	src/ast-inl.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/jump-target-heavy.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/jump-target-light.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/jump-target-light-inl.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

10 years, 6 months ago (2010-06-15 10:29:55 UTC) #2

LGTM

http://codereview.chromium.org/2828004/diff/1/2
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/2828004/diff/1/2#newcode590
src/arm/codegen-arm.cc:590: void CodeGenerator::LoadGlobalReceiver(Register
scratch) {
scratch is not used anymore.

http://codereview.chromium.org/2828004/diff/1/2#newcode932
src/arm/codegen-arm.cc:932: // On entry the non-constant side of the binary
operation is in tos_register_
Doesn't tos contain the result of performing the operation optimisticly?

http://codereview.chromium.org/2828004/diff/1/2#newcode949
src/arm/codegen-arm.cc:949: __ sub(r1, tos_register_,
Operand(Smi::FromInt(value_)));
Why does r0 not need to be loaded with value_?

http://codereview.chromium.org/2828004/diff/1/5
File src/arm/virtual-frame-arm.h (right):

http://codereview.chromium.org/2828004/diff/1/5#newcode348
src/arm/virtual-frame-arm.h:348: // Flushes all registers, but it puts a copy of
the top-of-stack in r0.
r0 -> r1

Expand Messages | Collapse Messages