Issue 28277: Linux valgrind: patch up flakey test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 28277: Linux valgrind: patch up flakey test (Closed)

Created:
11 years, 10 months ago by agl

Modified:
9 years, 7 months ago

Reviewers:
Paweł Hajdan Jr., Evan Martin, sky

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Linux valgrind: patch up flakey test Under valgrind, the new process doesn't have a chance to startup so this test fails most of the time.

Patch Set 1 #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	base/process_util_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

+sky, who has crusaded against flaky tests. Is there really nothing better we can do?

11 years, 10 months ago (2009-02-27 22:32:11 UTC) #2

Paweł Hajdan Jr.

11 years, 9 months ago (2009-02-28 14:42:23 UTC) #3

Maybe we could just rely on WaitForSingleProcess and don't check process count?
See also almost identical review http://codereview.chromium.org/18832 .

Expand Messages | Collapse Messages