Issue 2827055: Always show the 'Control sync from Google Dashboard' link on the sync options...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2827055: Always show the 'Control sync from Google Dashboard' link on the sync options... (Closed)

Created:
10 years, 5 months ago by tim (not reviewing)

Modified:
9 years, 6 months ago

Reviewers:
akalin

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Always show the 'Control sync from Google Dashboard' link on the sync options dialog. BUG=48844 TEST=open Personal Stuff on any platform, see dashboard link. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52740

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -31 lines)			Patch
M	chrome/browser/cocoa/preferences_window_controller.mm	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/gtk/options/content_page_gtk.cc	View	1 chunk	+16 lines, -19 lines	0 comments	Download
M	chrome/browser/views/options/content_page_view.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

akalin

Shouldn't you also remove the switch from chrome_switches.{h,cc} itself? On 2010/07/16 18:48:20, timsteele wrote: >

10 years, 5 months ago (2010-07-16 18:56:12 UTC) #2

tim (not reviewing)

On 2010/07/16 18:56:12, akalin wrote: > Shouldn't you also remove the switch from chrome_switches.{h,cc} itself? ...

10 years, 5 months ago (2010-07-16 19:34:40 UTC) #3

akalin

10 years, 5 months ago (2010-07-16 20:03:01 UTC) #4

LGTM

On 2010/07/16 19:34:40, timsteele wrote:
> On 2010/07/16 18:56:12, akalin wrote:
> > Shouldn't you also remove the switch from chrome_switches.{h,cc} itself?
> > 
> > On 2010/07/16 18:48:20, timsteele wrote:
> > >
> 
> touché
> done

Expand Messages | Collapse Messages