PyAuto: Automation hooks to get/set theme

PyAuto: Automation hooks to get/set theme

Add automation hooks to:
  - install a given theme
  - fetch info about the current theme
  - reset to default theme

Add a test exercising the above.


BUG=36215
TEST=python chrome/test/functional/themes.py

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52024

[John Grabowski, 2010-07-07 21:39:57]

LGTM

http://codereview.chromium.org/2827048/diff/1/2
File chrome/browser/automation/automation_provider.cc (right):

http://codereview.chromium.org/2827048/diff/1/2#newcode2370
chrome/browser/automation/automation_provider.cc:2370: }
Document lack of a theme returns an empty dict, not an error.  (Your code
assumes this).

http://codereview.chromium.org/2827048/diff/1/2#newcode2456
chrome/browser/automation/automation_provider.cc:2456:
handler_map["GetThemeInfo"] = &AutomationProvider::GetThemeInfo;
Add a quick comment that SetTheme handled by an InstallExtension call

http://codereview.chromium.org/2827048/diff/1/6
File chrome/test/pyautolib/pyauto.py (right):

http://codereview.chromium.org/2827048/diff/1/6#newcode655
chrome/test/pyautolib/pyauto.py:655: """Installs the given theme.
Installs the given theme synchronously.

[Paweł Hajdan Jr., 2010-07-08 07:41:20]

Drive-by with an automation comment. Please let me take another look before
committing.

http://codereview.chromium.org/2827048/diff/1/2
File chrome/browser/automation/automation_provider.cc (right):

http://codereview.chromium.org/2827048/diff/1/2#newcode2352
chrome/browser/automation/automation_provider.cc:2352:
browser->profile()->ClearTheme();
Hello, code duplication! We already have
AutomationProvider::ResetToDefaultTheme... but I understand the JSON interface
is more convenient. Do you have some ideas to avoid this duplication?

[Nirnimesh, 2010-07-08 17:54:13]

Removed ClearTheme() and using existing ResetToDefaultTheme()

http://codereview.chromium.org/2827048/diff/1/2
File chrome/browser/automation/automation_provider.cc (right):

http://codereview.chromium.org/2827048/diff/1/2#newcode2352
chrome/browser/automation/automation_provider.cc:2352:
browser->profile()->ClearTheme();
On 2010/07/08 07:41:21, Paweł Hajdan Jr. wrote:
> Hello, code duplication! We already have
> AutomationProvider::ResetToDefaultTheme... but I understand the JSON interface
> is more convenient. Do you have some ideas to avoid this duplication?

Sorry, I missed that. Removed ClearTheme()

http://codereview.chromium.org/2827048/diff/1/2#newcode2370
chrome/browser/automation/automation_provider.cc:2370: }
On 2010/07/07 21:39:57, John Grabowski wrote:
> Document lack of a theme returns an empty dict, not an error.  (Your code
> assumes this).
> 

Done.

http://codereview.chromium.org/2827048/diff/1/2#newcode2456
chrome/browser/automation/automation_provider.cc:2456:
handler_map["GetThemeInfo"] = &AutomationProvider::GetThemeInfo;
On 2010/07/07 21:39:57, John Grabowski wrote:
> Add a quick comment that SetTheme handled by an InstallExtension call
> 

Done.

[Paweł Hajdan Jr., 2010-07-08 18:16:30]

Code I commented in the drive-by LGTM.