Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2827036: Attempt to fix the ChromeFrame tests which rely on sending input to the IE ad... (Closed)

Created:
10 years, 5 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
amit
CC:
chromium-reviews, amit
Visibility:
Public.

Description

Attempt to fix the ChromeFrame tests which rely on sending input to the IE address bar to initiate navigation. These tests fail at times on the builders because of an incorrect URL actually being sent in to Chrome. Fix is to increase the delay between selecting the address bar via Alt+D and sending the url. TBR=amit Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51211

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome_frame/test/test_mock_with_web_server.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
10 years, 5 months ago (2010-06-29 23:20:50 UTC) #1
amit
10 years, 5 months ago (2010-06-30 02:32:44 UTC) #2
ok

On Tue, Jun 29, 2010 at 4:20 PM, <ananta@chromium.org> wrote:

> Reviewers: amit,
>
> Description:
> Attempt to fix the ChromeFrame tests which rely on sending input to the IE
> address bar to initiate navigation.
> These tests fail at times on the builders because of an incorrect URL
> actually
> being sent in to Chrome.
>
> Fix is to increase the delay between selecting the address bar via Alt+D
> and
> sending the url.
>
> TBR=amit
>
>
> Please review this at http://codereview.chromium.org/2827036/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome_frame/test/test_mock_with_web_server.cc
>
>
> Index: chrome_frame/test/test_mock_with_web_server.cc
> ===================================================================
> --- chrome_frame/test/test_mock_with_web_server.cc      (revision 51059)
> +++ chrome_frame/test/test_mock_with_web_server.cc      (working copy)
> @@ -223,7 +223,7 @@
>       simulate_input::SendCharA, 'd', simulate_input::ALT),
>       delay);
>
> -  const unsigned int kInterval = 100;
> +  const unsigned int kInterval = 500;
>   int next_delay = delay + kInterval;
>
>   loop->PostDelayedTask(FROM_HERE, NewRunnableFunction(
>
>
>

Powered by Google App Engine
This is Rietveld 408576698