Issue 2827033: Even more cleanup of es5 test expectations. ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2827033: Even more cleanup of es5 test expectations. ... (Closed)

Created:
10 years, 5 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Even more cleanup of es5 test expectations. Removed expectations for tests that was removed in the latest revision. Also changed FAIL_OK to FAIL for test that we should implement but currently don't (thanks to lasse for noticing this). Committed: http://code.google.com/p/v8/source/detail?r=4973

Patch Set 1 #

Total comments: 6

Patch Set 2 : '' #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -51 lines)			Patch
	M	test/es5conform/es5conform.status	View	1	5 chunks	+43 lines, -51 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM http://codereview.chromium.org/2827033/diff/1/2 File test/es5conform/es5conform.status (right): http://codereview.chromium.org/2827033/diff/1/2#newcode230 test/es5conform/es5conform.status:230: # Wront test - the test in the ...

10 years, 5 months ago (2010-06-29 08:54:28 UTC) #2

Rico

10 years, 5 months ago (2010-06-29 09:00:31 UTC) #3

http://codereview.chromium.org/2827033/diff/1/2
File test/es5conform/es5conform.status (right):

http://codereview.chromium.org/2827033/diff/1/2#newcode230
test/es5conform/es5conform.status:230: # Wront test - the test in the end should
be i === true.
On 2010/06/29 08:54:28, Lasse Reichstein wrote:
> "Wrong" (or, preferably, "Bad").
> "in the end" -> "at the end".
> Quotes around "i === true".
> 

Done (plus every other wrong->bad).

http://codereview.chromium.org/2827033/diff/1/2#newcode245
test/es5conform/es5conform.status:245: # Wrong tests, path in test file is
wrong. This will crash the test
On 2010/06/29 08:54:28, Lasse Reichstein wrote:
> "Bad tests - "

Done.

http://codereview.chromium.org/2827033/diff/1/2#newcode250
test/es5conform/es5conform.status:250: # Wrong test - deleting the property on o
in callbackfn will
On 2010/06/29 08:54:28, Lasse Reichstein wrote:
> Bad.

Done.

Expand Messages | Collapse Messages