Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: update_check_action_unittest.cc

Issue 2827032: AU: Send board (e.g. x86-generic) to update server in query. (Closed) Base URL: ssh://git@chromiumos-git/update_engine.git
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « update_check_action.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: update_check_action_unittest.cc
diff --git a/update_check_action_unittest.cc b/update_check_action_unittest.cc
index c730b407102b20abaab39d3222a9cc22576cbb9c..e2e7410ba4f2bf9496f600e8cdd47fab6671bc3e 100644
--- a/update_check_action_unittest.cc
+++ b/update_check_action_unittest.cc
@@ -159,6 +159,7 @@ TEST(UpdateCheckActionTest, NoUpdateTest) {
UpdateCheckParams::kOsPlatform,
UpdateCheckParams::kOsVersion,
"", // os_sp
+ "x86-generic",
UpdateCheckParams::kAppId,
"0.1.0.0",
"en-US",
@@ -180,6 +181,7 @@ TEST(UpdateCheckActionTest, ValidUpdateTest) {
UpdateCheckParams::kOsPlatform,
UpdateCheckParams::kOsVersion,
"service_pack",
+ "arm-generic",
UpdateCheckParams::kAppId,
"0.1.0.0",
"en-US",
@@ -215,6 +217,7 @@ TEST(UpdateCheckActionTest, NoOutputPipeTest) {
UpdateCheckParams::kOsPlatform,
UpdateCheckParams::kOsVersion,
"", // os_sp
+ "", // os_board
UpdateCheckParams::kAppId,
"0.1.0.0",
"en-US",
@@ -248,6 +251,7 @@ TEST(UpdateCheckActionTest, InvalidXmlTest) {
UpdateCheckParams::kOsPlatform,
UpdateCheckParams::kOsVersion,
"service_pack",
+ "x86-generic",
UpdateCheckParams::kAppId,
"0.1.0.0",
"en-US",
@@ -269,6 +273,7 @@ TEST(UpdateCheckActionTest, MissingStatusTest) {
UpdateCheckParams::kOsPlatform,
UpdateCheckParams::kOsVersion,
"service_pack",
+ "x86-generic",
UpdateCheckParams::kAppId,
"0.1.0.0",
"en-US",
@@ -293,6 +298,7 @@ TEST(UpdateCheckActionTest, InvalidStatusTest) {
UpdateCheckParams::kOsPlatform,
UpdateCheckParams::kOsVersion,
"service_pack",
+ "x86-generic",
UpdateCheckParams::kAppId,
"0.1.0.0",
"en-US",
@@ -317,6 +323,7 @@ TEST(UpdateCheckActionTest, MissingNodesetTest) {
UpdateCheckParams::kOsPlatform,
UpdateCheckParams::kOsVersion,
"service_pack",
+ "x86-generic",
UpdateCheckParams::kAppId,
"0.1.0.0",
"en-US",
@@ -341,6 +348,7 @@ TEST(UpdateCheckActionTest, MissingFieldTest) {
UpdateCheckParams::kOsPlatform,
UpdateCheckParams::kOsVersion,
"service_pack",
+ "x86-generic",
UpdateCheckParams::kAppId,
"0.1.0.0",
"en-US",
@@ -400,6 +408,7 @@ TEST(UpdateCheckActionTest, TerminateTransferTest) {
UpdateCheckParams::kOsPlatform,
UpdateCheckParams::kOsVersion,
"", // os_sp
+ "", // os_board
UpdateCheckParams::kAppId,
"0.1.0.0",
"en-US",
@@ -440,6 +449,7 @@ TEST(UpdateCheckActionTest, XmlEncodeTest) {
UpdateCheckParams::kOsPlatform,
UpdateCheckParams::kOsVersion,
"testtheservice_pack>",
+ "x86 generic",
UpdateCheckParams::kAppId,
"0.1.0.0",
"en-US",
@@ -460,6 +470,7 @@ TEST(UpdateCheckActionTest, XmlEncodeTest) {
EXPECT_EQ(post_str.find("testtheuser_id<"), string::npos);
EXPECT_NE(post_str.find("testtheservice_pack>"), string::npos);
EXPECT_EQ(post_str.find("testtheservice_pack>"), string::npos);
+ EXPECT_NE(post_str.find("x86 generic"), string::npos);
}
TEST(UpdateCheckActionTest, XmlDecodeTest) {
@@ -468,6 +479,7 @@ TEST(UpdateCheckActionTest, XmlDecodeTest) {
UpdateCheckParams::kOsPlatform,
UpdateCheckParams::kOsVersion,
"service_pack",
+ "x86-generic",
UpdateCheckParams::kAppId,
"0.1.0.0",
"en-US",
@@ -498,6 +510,7 @@ TEST(UpdateCheckActionTest, ParseIntTest) {
UpdateCheckParams::kOsPlatform,
UpdateCheckParams::kOsVersion,
"service_pack",
+ "the_board",
UpdateCheckParams::kAppId,
"0.1.0.0",
"en-US",
« no previous file with comments | « update_check_action.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698