Issue 2827029: Merge 50561 - Fix a crash when we try to close a js dialog that wasn't shown....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2827029: Merge 50561 - Fix a crash when we try to close a js dialog that wasn't shown.... (Closed)

Created:
10 years, 5 months ago by inferno

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/375/src/

Visibility:
Public.

Merge 50561 - Fix a crash when we try to close a js dialog that wasn't shown. The dialog has been queued, but it hasn't been shown because a different dialog is already showing. We try to close the dialog because a page navigation has occurred. BUG=47056 TEST=None Review URL: http://codereview.chromium.org/2803017 TBR=tony@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51022

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -2 lines)			Patch
M	chrome/browser/app_modal_dialog_gtk.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/app_modal_dialog_win.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/js_modal_dialog.cc	View	3 chunks	+5 lines, -2 lines	0 comments	Download

Total messages: 1 (0 generated)