Issue 2827022: X64: Change some fpu operations to use XMM registers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2827022: X64: Change some fpu operations to use XMM registers. (Closed)

Created:
10 years, 6 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
William Hesse

CC:
v8-dev

Visibility:
Public.

Description

X64: Change some fpu operations to use XMM registers.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed review comment. #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+125 lines, -52 lines)			Patch
M	src/x64/assembler-x64.h	View		3 chunks	+8 lines, -0 lines	0 comments	Download
M	src/x64/assembler-x64.cc	View		4 chunks	+67 lines, -0 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View		2 chunks	+6 lines, -9 lines	0 comments	Download
M	src/x64/disasm-x64.cc	View		3 chunks	+22 lines, -4 lines	0 comments	Download
M	src/x64/ic-x64.cc	View	1	7 chunks	+22 lines, -39 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

10 years, 6 months ago (2010-06-23 13:37:25 UTC) #2

LGTM.

http://codereview.chromium.org/2827022/diff/1/6
File src/x64/ic-x64.cc (right):

http://codereview.chromium.org/2827022/diff/1/6#newcode1187
src/x64/ic-x64.cc:1187: __ xorl(rdx, rdx);
Why not Set(rdx, 0)?  That automatically does the correct thing.

Expand Messages | Collapse Messages